Review 12.4 Merged

81966[BUGFIX] Prevent JS SyntaxError on extension installation

Oli Bartsch CR +2 V +2 Normal +61 −45 updated 11/26/23, 19:51

Commit message

In case an extension should be installed
via the extension manager, containing code
which might stop the PHP request, e.g. the
common "defined('TYPO3_MODE') or die();" check,
the corresponding JS component does no longer
generate a SyntaxError on calling .json()
on the empty response body.

Instead, the error is caught and the integrator
is being informed via a flash message.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch uploaded patch set 1 11/26/23, 18:16

  2. core-ci voted on patch set 1 V +1 11/26/23, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49953

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 11/26/23, 19:51

  4. Oli Bartsch merged patch set 2 11/26/23, 19:51