Review 11.5 Merged

81971[BUGFIX] Avoid side effect in acceptance tests

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 11/27/23, 10:59

Commit message

FalMetadataCest changes the title of styleguide
'bus_lane.jpg'. InlineFalCest uses the title to
look up details in element information modal and
stumbles. Check for the filename only to avoid
this side effect.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 11/27/23, 10:10

  2. core-ci voted on patch set 1 V +1 11/27/23, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49970

  3. core-ci commented on patch set 1 11/27/23, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49971

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 11/27/23, 10:57

  5. Jasmina Ließmann voted on patch set 1 CR +1 V +1 11/27/23, 10:58

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 11/27/23, 10:59

  7. Christian Kuhn merged patch set 2 11/27/23, 10:59