81972[TASK] Add title and aria-label to clear input button
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Rath-Ulrich +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Rath-Ulrich +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/input/clearable.ts+5 −0
- typo3/sysext/backend/Classes/Controller/LoginController.php2+14 −0
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+12 −0
- typo3/sysext/backend/Resources/Public/JavaScript/input/clearable.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
Review log 78
-
Willi Wehmeier uploaded patch set 1 11/27/23, 11:11
-
core-ci voted on patch set 1 V +1 11/27/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49975
-
Christian Rath-Ulrich voted on patch set 1 CR +1 V +1 11/27/23, 13:48
-
Anja Leichsenring voted on patch set 1 CR +2 V +2 01/31/24, 07:40
-
Anja Leichsenring merged patch set 2 01/31/24, 07:41
-
Benjamin Franzke commented on patch set 2 01/31/24, 07:43
Post -1LoginController.php:304Olly worked hard to remove all inline JS, now we should not add it back. -
Anja Leichsenring commented on patch set 2 01/31/24, 07:49
LoginController.php:304Reply Unresolvedshould I revert? -
Benjamin Franzke wrote 01/31/24, 07:56
Created a revert of this change as I0f2fed9b56484697ddb97fee1a905c83fbc49107