Review main Merged

81972[TASK] Add title and aria-label to clear input button

Willi Wehmeier CR +2 V +2 Easy +35 −1 updated 03/11/24, 07:59

Commit message

Add a title and aria-label to the clear input button added
on all input fields with the class t3js-clearable.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Rath-Ulrich +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Rath-Ulrich +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 78

  1. Willi Wehmeier uploaded patch set 1 11/27/23, 11:11

  2. core-ci voted on patch set 1 V +1 11/27/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49975

  3. Christian Rath-Ulrich voted on patch set 1 CR +1 V +1 11/27/23, 13:48

  4. Anja Leichsenring voted on patch set 1 CR +2 V +2 01/31/24, 07:40

  5. Anja Leichsenring merged patch set 2 01/31/24, 07:41

  6. Benjamin Franzke commented on patch set 2 01/31/24, 07:43

    Post -1

    LoginController.php:304

    Olly worked hard to remove all inline JS, now we should not add it back.
  7. Anja Leichsenring commented on patch set 2 01/31/24, 07:49

    LoginController.php:304 Reply Unresolved

    should I revert?
  8. Benjamin Franzke wrote 01/31/24, 07:56

    Created a revert of this change as I0f2fed9b56484697ddb97fee1a905c83fbc49107