Review main Merged

81975[TASK] Avoid unnecessary null-coalesence operators etc

Benni Mack CR +2 V +2 Hard +84 −189 updated 12/01/23, 07:40

Commit message

When PHP 8.0 support was added, a lot of places
received extra checks with the $conf ?? [].

PHPStan complained about this now, as methods
already have native PHP types added now, and the
check is not needed anymore, so it can be simplified

A few other places did not receive proper PHPdoc
annotations which has been fixed as well.

In addition, some str_ends_with calls are migrated.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1115

  1. Benni Mack uploaded patch set 1 11/27/23, 14:23

  2. core-ci voted on patch set 1 V -1 11/27/23, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50003

  3. Benni Mack uploaded patch set 2 V -1 11/27/23, 16:00

  4. Christian Kuhn commented on patch set 2 CR -1 11/27/23, 16:24

    ImageContentObject.php:83

    we're not sure $conf is not null until $conf is not type hinted as array in method signature.

    CategoryMenuUtility.php:48

    $configuration is not necessarily an array here.
  5. core-ci voted on patch set 2 V -1 11/27/23, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50013

  6. Benni Mack uploaded patch set 3 CR -1 V -1 11/30/23, 07:53

  7. Benni Mack commented on patch set 3 11/30/23, 07:53

    ImageContentObject.php:83 Reply

    Done

    CategoryMenuUtility.php:48 Reply

    Done
  8. core-ci voted on patch set 3 V -1 11/30/23, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50150

  9. Benni Mack uploaded patch set 4 V -1 11/30/23, 12:13

  10. core-ci voted on patch set 4 V +1 11/30/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50160

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 11/30/23, 12:47

  12. Oli Bartsch voted on patch set 4 CR +1 11/30/23, 16:44

  13. Oli Bartsch voted on patch set 4 V +1 12/01/23, 06:49

  14. Oli Bartsch voted on patch set 4 CR +2 V +2 12/01/23, 07:39

  15. Oli Bartsch merged patch set 5 12/01/23, 07:40