81975[TASK] Avoid unnecessary null-coalesence operators etc
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 24
- Build/phpstan/phpstan-baseline.neon+4 −114
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/core/Classes/Configuration/Richtext.php+1 −1
- typo3/sysext/core/Classes/Package/Package.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TypoScriptService.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+14 −14
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php2+1 −1
- typo3/sysext/frontend/Classes/ContentObject/CaseContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+3 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+8 −8
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+6 −9
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+5 −5
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php2+16 −15
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ScalableVectorGraphicsContentObject.php+5 −5
- typo3/sysext/frontend/Classes/DataProcessing/FilesProcessor.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+1 −0
Review log 1115
-
Benni Mack uploaded patch set 1 11/27/23, 14:23
-
core-ci voted on patch set 1 V -1 11/27/23, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50003
-
Benni Mack uploaded patch set 2
V -111/27/23, 16:00 -
Christian Kuhn commented on patch set 2 CR -1 11/27/23, 16:24
CategoryMenuUtility.php:48$configuration is not necessarily an array here. -
core-ci voted on patch set 2 V -1 11/27/23, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50013
-
Benni Mack uploaded patch set 3
CR -1V -111/30/23, 07:53 -
Benni Mack commented on patch set 3 11/30/23, 07:53
ImageContentObject.php:83ReplyDoneCategoryMenuUtility.php:48ReplyDone -
core-ci voted on patch set 3 V -1 11/30/23, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50150
-
Benni Mack uploaded patch set 4
V -111/30/23, 12:13 -
core-ci voted on patch set 4 V +1 11/30/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50160
-
Andreas Kienast voted on patch set 4 CR +1 V +1 11/30/23, 12:47
-
Oli Bartsch voted on patch set 4 CR +1 11/30/23, 16:44
-
Oli Bartsch voted on patch set 4 V +1 12/01/23, 06:49
-
Oli Bartsch voted on patch set 4 CR +2 V +2 12/01/23, 07:39
-
Oli Bartsch merged patch set 5 12/01/23, 07:40
ImageContentObject.php:83