Review main Merged

81992[TASK] Simplify TSFE->getFromCache() cache details

Christian Kuhn CR +2 V +2 Easy +8 −23 updated 11/29/23, 07:05

Commit message

$typoscriptCache is initialized to either a cache frontend
instance or null depending on $this->no_cache. The cache
argument is nullable in getTreeBySysTemplateRowsAndSite().
We can skip some if constructs within getFromCache().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 11/28/23, 11:12

  2. core-ci voted on patch set 1 V +1 11/28/23, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50051

  3. Andreas Kienast voted on patch set 1 CR +1 11/28/23, 11:56

  4. Andreas Kienast voted on patch set 1 V +1 11/28/23, 12:33

  5. Christian Kuhn voted on patch set 1 CR -1 11/29/23, 06:42

  6. Christian Kuhn uploaded patch set 2 CR +1 V +1 11/29/23, 06:46

  7. core-ci voted on patch set 2 V +1 11/29/23, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50085

  8. Benni Mack voted on patch set 2 CR +1 V +1 11/29/23, 06:52

  9. Andreas Kienast voted on patch set 2 CR +1 V +1 11/29/23, 07:04

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 11/29/23, 07:05

  11. Christian Kuhn merged patch set 3 11/29/23, 07:05