Review main Merged

81996[BUGFIX] Prevent double encoding in field controls

Oli Bartsch CR +2 V +2 Easy +13 −13 updated 11/29/23, 09:12

Commit message

The link attributes of a field control are added to
the link tag using implodeAttributes() with the second
parameter `xhtmlSafe` set to `true`. To prevent double
encoding, previously applied "hsc" calls are removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 68

  1. Oli Bartsch uploaded patch set 1 11/28/23, 14:49

  2. core-ci voted on patch set 1 V -1 11/28/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50059

  3. Oli Bartsch uploaded patch set 2 V -1 11/28/23, 18:07

  4. core-ci voted on patch set 2 V +1 11/28/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50063

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 11/29/23, 06:06

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 11/29/23, 07:07

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 11/29/23, 09:12

  8. Oli Bartsch merged patch set 3 11/29/23, 09:12