Review main Merged

82007[TASK] Avoid TSFE->type

Christian Kuhn CR +2 V +2 Easy +11 −17 updated 11/29/23, 07:41

Commit message

Internal property TypoScriptFrontendController->type
is a duplication of PageArguments->getPageType().
This can be used directly instead of parking that
state in TSFE a second time.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 11/29/23, 07:21

  2. Benni Mack voted on patch set 1 CR +1 V +1 11/29/23, 07:26

  3. core-ci voted on patch set 1 V +1 11/29/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50087

  4. Andreas Kienast commented on patch set 1 11/29/23, 07:31

    TypoScriptFrontendController.php:269

    nitpick
  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 11/29/23, 07:35

  6. Christian Kuhn commented on patch set 1 11/29/23, 07:35

    TypoScriptFrontendController.php:269 Reply

    Done
  7. Andreas Kienast voted on patch set 2 CR +1 V +1 11/29/23, 07:35

  8. Anja Leichsenring voted on patch set 2 CR +1 V +1 11/29/23, 07:37

  9. Anja Leichsenring voted on patch set 2 CR +2 V +2 11/29/23, 07:37

  10. Anja Leichsenring merged patch set 3 11/29/23, 07:37

  11. core-ci voted on patch set 2 V +1 11/29/23, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50089