Review main Merged

82008[TASK] Add labels to docheader action-menu dropdown

Willi Wehmeier CR +2 V +2 Normal +97 −11 updated 03/15/24, 11:26

Commit message

This patch adds a label to the action-menu used by most of
the core extensions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 2938

Show 913 earlier messages
  1. Willi Wehmeier uploaded patch set 1 11/29/23, 07:34

  2. core-ci voted on patch set 1 V +1 11/29/23, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50088

  3. Simon Schaufelberger commented on patch set 1 12/21/23, 00:09

    locallang.xlf:138

    I'm thinking if it would be better to use the one from the backend extension here again to avoid duplicate keys across multiple extensions
  4. Willi Wehmeier uploaded patch set 2 V +1 12/21/23, 06:48

  5. Willi Wehmeier commented on patch set 2 12/21/23, 06:49

    locallang.xlf:138 Reply

    Done. I removed the new translation string and and used the one from the backend extension.
  6. core-ci voted on patch set 2 V +1 12/21/23, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50857

  7. Simon Schaufelberger uploaded patch set 3 V +1 12/23/23, 00:18

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/23/23, 00:18

  9. core-ci voted on patch set 3 V +1 12/23/23, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50918

  10. Christian Rath-Ulrich voted on patch set 3 CR +1 V +1 01/08/24, 12:42

  11. Benjamin Kott uploaded patch set 4 CR +1 V +1 03/01/24, 09:59

  12. core-ci voted on patch set 4 V +1 03/01/24, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53745

  13. Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/01/24, 11:49

  1. Willi Wehmeier uploaded patch set 5 CR +1 V +1 03/04/24, 07:02

  2. core-ci voted on patch set 5 V +1 03/04/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53804

  3. Andreas Kienast commented on patch set 5 CR -1 03/04/24, 07:59

    on it

    locallang.xlf:19

    nitpick: please indent xlf files with tabs
  4. Andreas Kienast uploaded patch set 6 CR -1 V +1 03/04/24, 08:06

  5. Andreas Kienast commented on patch set 6 03/04/24, 08:06

    SelectBoxJumpMenu.html:6

    I think I'd be better to have the label next to the field, not above.
  6. Andreas Kienast commented on patch set 6 03/04/24, 08:07

    locallang.xlf:19 Reply

    Done
  7. core-ci voted on patch set 6 V +1 03/04/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53809

  8. Willi Wehmeier commented on patch set 6 03/04/24, 08:18

    SelectBoxJumpMenu.html:6 Reply

    I can change that. I just wasn't sure about placing the label next to the dropdown which causes, that the dropdown position varies in that case.
  9. Willi Wehmeier uploaded patch set 7 V +1 03/15/24, 07:12

  10. core-ci voted on patch set 7 V +1 03/15/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54562

  11. Benjamin Kott uploaded patch set 8 V +1 03/15/24, 10:25

  12. Benjamin Kott commented on patch set 7 03/15/24, 10:26

    SelectBoxJumpMenu.html:6 Reply

    We are hiding the label for now, but keeping it accessible for screen readers. This should solve the issue here through the testing. We need a different solution for this, in the future.
  13. Benjamin Kott commented on patch set 8 03/15/24, 10:26

    SelectBoxJumpMenu.html:6 Reply

    Done
  14. Benjamin Kott voted on patch set 8 CR +1 V +1 03/15/24, 10:28

  15. core-ci voted on patch set 8 V +1 03/15/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54575

  16. Simon Schaufelberger voted on patch set 8 CR +1 V +1 03/15/24, 10:44

  17. Willi Wehmeier voted on patch set 8 CR +1 V +1 03/15/24, 11:01

  18. Andreas Kienast voted on patch set 8 CR +2 V +2 03/15/24, 11:02

  19. Andreas Kienast commented on patch set 8 V 0 CR -1 03/15/24, 11:07

    Found a forgotten menu in `typo3/sysext/reports/Classes/Controller/ReportController.php`...
  20. Willi Wehmeier uploaded patch set 9 CR +1 V +1 03/15/24, 11:17

  21. Andreas Kienast commented on patch set 9 CR +1 V +1 03/15/24, 11:20

    Reply

    Done
  22. Benjamin Kott voted on patch set 9 CR +1 V +1 03/15/24, 11:20

  23. Andreas Kienast voted on patch set 9 CR +2 V +2 03/15/24, 11:21

  24. core-ci voted on patch set 9 V +1 03/15/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54582

  25. Andreas Kienast merged patch set 10 03/15/24, 11:26