82008[TASK] Add labels to docheader action-menu dropdown
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+5 −0
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+5 −1
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+6 −0
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/backend/Resources/Private/Partials/Menus/SelectBoxJumpMenu.html4+9 −4
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+6 −0
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php+5 −0
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+11 −5
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+5 −0
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+5 −0
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+5 −0
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf2+7 −0
- typo3/sysext/reports/Classes/Controller/ReportController.php+3 −0
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+5 −0
- typo3/sysext/viewpage/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+5 −1
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+3 −0
Review log 2938
Show 913 earlier messages
-
Willi Wehmeier uploaded patch set 1 11/29/23, 07:34
-
core-ci voted on patch set 1 V +1 11/29/23, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50088
-
Simon Schaufelberger commented on patch set 1 12/21/23, 00:09
-
Willi Wehmeier uploaded patch set 2
V +112/21/23, 06:48 -
Willi Wehmeier commented on patch set 2 12/21/23, 06:49
locallang.xlf:138ReplyDone. I removed the new translation string and and used the one from the backend extension. -
core-ci voted on patch set 2 V +1 12/21/23, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50857
-
Simon Schaufelberger uploaded patch set 3
V +112/23/23, 00:18 -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/23/23, 00:18
-
core-ci voted on patch set 3 V +1 12/23/23, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50918
-
Christian Rath-Ulrich voted on patch set 3 CR +1 V +1 01/08/24, 12:42
-
Benjamin Kott uploaded patch set 4
CR +1V +103/01/24, 09:59 -
core-ci voted on patch set 4 V +1 03/01/24, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53745
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/01/24, 11:49
-
Willi Wehmeier uploaded patch set 5
CR +1V +103/04/24, 07:02 -
core-ci voted on patch set 5 V +1 03/04/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53804
-
Andreas Kienast commented on patch set 5 CR -1 03/04/24, 07:59
on itlocallang.xlf:19nitpick: please indent xlf files with tabs -
Andreas Kienast uploaded patch set 6
CR -1V +103/04/24, 08:06 -
Andreas Kienast commented on patch set 6 03/04/24, 08:06
SelectBoxJumpMenu.html:6I think I'd be better to have the label next to the field, not above. -
Andreas Kienast commented on patch set 6 03/04/24, 08:07
locallang.xlf:19ReplyDone -
core-ci voted on patch set 6 V +1 03/04/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53809
-
Willi Wehmeier commented on patch set 6 03/04/24, 08:18
SelectBoxJumpMenu.html:6ReplyI can change that. I just wasn't sure about placing the label next to the dropdown which causes, that the dropdown position varies in that case. -
Willi Wehmeier uploaded patch set 7
V +103/15/24, 07:12 -
core-ci voted on patch set 7 V +1 03/15/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54562
-
Benjamin Kott uploaded patch set 8
V +103/15/24, 10:25 -
Benjamin Kott commented on patch set 7 03/15/24, 10:26
SelectBoxJumpMenu.html:6ReplyWe are hiding the label for now, but keeping it accessible for screen readers. This should solve the issue here through the testing. We need a different solution for this, in the future. -
Benjamin Kott commented on patch set 8 03/15/24, 10:26
SelectBoxJumpMenu.html:6ReplyDone -
Benjamin Kott voted on patch set 8 CR +1 V +1 03/15/24, 10:28
-
core-ci voted on patch set 8 V +1 03/15/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54575
-
Simon Schaufelberger voted on patch set 8 CR +1 V +1 03/15/24, 10:44
-
Willi Wehmeier voted on patch set 8 CR +1 V +1 03/15/24, 11:01
-
Andreas Kienast voted on patch set 8 CR +2 V +2 03/15/24, 11:02
-
Andreas Kienast commented on patch set 8 V 0 CR -1 03/15/24, 11:07
Found a forgotten menu in `typo3/sysext/reports/Classes/Controller/ReportController.php`... -
Willi Wehmeier uploaded patch set 9
CR +1V +103/15/24, 11:17 -
Andreas Kienast commented on patch set 9 CR +1 V +1 03/15/24, 11:20
Reply
Done -
Benjamin Kott voted on patch set 9 CR +1 V +1 03/15/24, 11:20
-
Andreas Kienast voted on patch set 9 CR +2 V +2 03/15/24, 11:21
-
core-ci voted on patch set 9 V +1 03/15/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54582
-
Andreas Kienast merged patch set 10 03/15/24, 11:26
locallang.xlf:138