82012[BUGFIX] Avoid <o:p> tags pasted from MS Word into CKEditor5
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/Configuration/CKEditor5Migrator.php+3 −1
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-102507-DefaultCKEditor5AllowedClassesAndDataAttributesConfiguratedReverted.rstnew+50 −0
- typo3/sysext/core/Tests/Unit/Configuration/CKEditor5MigratorTest.php+6 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Base.yaml+0 −4
Review log 1621
-
Benjamin Franzke commented on patch set 1 11/28/23, 14:31
Cherry Picked from branch 12.4. -
Benjamin Franzke marked it ready for review 11/28/23, 14:31
-
core-ci voted on patch set 1 V +1 11/28/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50057
-
Garvin Hicking commented on patch set 1 11/28/23, 22:50
This still also scrubs tags like "script" at some later point, even if they match [a-z] right? -
Benjamin Franzke commented on patch set 1 CR -2 11/29/23, 06:47
Reply
Yes, it is escaped due to our html-sanitizer, but it is annoying to have it kinda allowed in the first place (although not being executed). I'm really leaning towards dropping this `classes: true` compat thingy (in v12 with an Important.rst), its problems are really annoying. Side note: that's all just because I wanted to assure that a v10/v11 updated to v12 doesn't loose HTML data when an editor opens an existing record and simply saves it – that's why I've added `classes: true` at all – other than that all allowed classes should be defined as style sets, which makes them implicitly allowed, so `classes: true` would not be needed for "properly" configured installations. Also with `classes: true` we'll always see the annoying ms-office classes in HTML, since all of them count as allowed while they are pasted. Thanks for the heads up. So I'm -2 this for now, I need to think about this… -
Benjamin Franzke uploaded patch set 2
V +112/11/23, 17:26Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke voted on patch set 2 CR 0 12/11/23, 17:26
-
core-ci voted on patch set 2 V +1 12/11/23, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50568
-
Benjamin Franzke commented on patch set 2 12/11/23, 17:40
Reply
Decided to drop this rule as the downsides outweighed the benefits. -
Benjamin Franzke uploaded patch set 3
V +112/11/23, 17:59 -
Benjamin Franzke uploaded patch set 4 12/11/23, 18:01
-
core-ci voted on patch set 3 V +1 12/11/23, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50569
-
core-ci voted on patch set 4 V +1 12/11/23, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50570
-
Georg Ringer voted on patch set 3 CR +1 V +1 12/11/23, 19:54
-
Benjamin Franzke updated the commit message in patch set 5
V +112/12/23, 06:16 -
core-ci voted on patch set 5 V +1 12/12/23, 06:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50575
-
Benni Mack voted on patch set 5 CR +1 V +1 12/12/23, 08:35
-
Benjamin Franzke commented on patch set 5 12/12/23, 09:11
FYI: Tested against/with the update to CKEditor5 v40.2, this patch is still needed: > 82172: [TASK] Update ckeditor5 to v40.2 | https://review.typo3.org/c/Packages/TYPO3.CMS/+/82172 -
Georg Ringer voted on patch set 5 CR +1 V +1 12/12/23, 09:23
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 12/12/23, 09:27
-
Benjamin Franzke merged patch set 6 12/12/23, 09:27