Review 12.4 Merged

82017[BUGFIX] Respect endtime of page when calculating the lifetime

Benni Mack CR +2 V +2 Easy +5 −0 updated 12/01/23, 07:38

Commit message

When the endtime of a page is lower than the default lifetime (24h),
the calculation did not respect the endtime and set the lifetime to
default lifetime. This lead to cache entries with incorrect lifetimes.

The upper bound of the cache lifetime is now additionally clamped to
the endtime of the current page.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Benni Mack commented on patch set 1 11/30/23, 17:06

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/30/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50176

  3. Benjamin Franzke updated the commit message in patch set 2 V +1 12/01/23, 06:30

  4. core-ci voted on patch set 2 V +1 12/01/23, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50191

  5. Benjamin Franzke voted on patch set 2 CR +2 V +2 12/01/23, 07:38

  6. Benjamin Franzke merged patch set 3 12/01/23, 07:38