Review main Merged

82037[TASK] Early return in case title tag should not be rendered

Oli Bartsch CR +2 V +2 Easy +5 −4 updated 11/29/23, 19:13

Commit message

To avoid unnecessary initialization of page
title providers and calling any stdWrap, an
early return is added to `TSFE::generatePageTitle`
for the case that `noPageTitle` is set to "2",
as this means do not render the title tag at all.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 11/29/23, 14:17

  2. core-ci voted on patch set 1 V +1 11/29/23, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50121

  3. Andreas Kienast voted on patch set 1 CR +1 11/29/23, 14:38

  4. Oliver Klee voted on patch set 1 CR +1 11/29/23, 14:47

  5. Andreas Kienast voted on patch set 1 V +1 11/29/23, 14:48

  6. Christian Kuhn voted on patch set 1 CR +1 V +1 11/29/23, 18:25

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 11/29/23, 19:13

  8. Christian Kuhn merged patch set 2 11/29/23, 19:13