Review main Merged

82040[BUGFIX] Properly set a request object in FormPersistenceManager

Oli Bartsch CR +2 V +2 Easy +13 −9 updated 11/29/23, 20:59

Commit message

Due to the removed fallback to $GLOBALS['TYPO3_REQUEST']
in #102513, it's required to properly set a request
object to a configuration manager instance.

This is now done in FormPersistenceManager, which
previously just set a fake request to the global
variable but did not use the setRequest() method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Oli Bartsch uploaded patch set 1 11/29/23, 16:05

  2. core-ci voted on patch set 1 V +1 11/29/23, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50127

  3. Benni Mack commented on patch set 1 11/29/23, 16:49

    FormPersistenceManager.php:86

    maybe you can add normalizedParams as well as property
  4. Oli Bartsch uploaded patch set 2 V +1 11/29/23, 17:59

  5. Oli Bartsch commented on patch set 2 11/29/23, 17:59

    FormPersistenceManager.php:86 Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/29/23, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50136

  7. Christian Kuhn uploaded patch set 3 V +1 11/29/23, 18:56

  8. core-ci voted on patch set 3 V +1 11/29/23, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50137

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/23, 19:03

  10. Benni Mack voted on patch set 3 CR +1 V +1 11/29/23, 20:47

  11. Stefan Bürk voted on patch set 3 CR +1 V +1 11/29/23, 20:49

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 11/29/23, 20:59

  13. Christian Kuhn merged patch set 4 11/29/23, 20:59