Review main Merged

82045[TASK] Simplify PageRepository code

Benni Mack CR +2 V +2 Hard +344 −316 updated 01/03/24, 06:10

Commit message

This change reduces some cognitive load
in some methods to use early returns
instead of nested if statements.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1017

  1. Benni Mack uploaded patch set 1 11/30/23, 07:30

  2. core-ci voted on patch set 1 V -1 11/30/23, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50148

  3. Benni Mack uploaded patch set 2 V -1 12/27/23, 21:51

  4. core-ci voted on patch set 2 V -1 12/27/23, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50969

  5. Benni Mack uploaded patch set 3 V -1 12/27/23, 22:03

  6. core-ci voted on patch set 3 V +1 12/27/23, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50970

  7. Benni Mack uploaded patch set 4 V +1 12/27/23, 22:21

  8. core-ci voted on patch set 4 V +1 12/27/23, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50971

  9. Benni Mack uploaded patch set 5 V +1 12/28/23, 22:07

  10. core-ci voted on patch set 5 V +1 12/28/23, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50988

  11. Benni Mack updated the commit message in patch set 6 V +1 12/28/23, 22:16

  12. core-ci voted on patch set 6 V +1 12/28/23, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50989

  13. Oli Bartsch uploaded patch set 7 V +1 01/02/24, 12:31

  14. core-ci voted on patch set 7 V +1 01/02/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51048

  15. Oli Bartsch voted on patch set 7 CR +1 V +1 01/02/24, 12:58

  16. Anja Leichsenring voted on patch set 7 CR +2 V +2 01/03/24, 06:10

  17. Anja Leichsenring merged patch set 8 01/03/24, 06:10