Review 12.4 Merged

82046[BUGFIX] Prevent endless loop in t3editor when using '/*' literal

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 11/30/23, 08:43

Commit message

When entering the sequence "/*" into any t3editor instance
(i.e. TypoScript editor in the backend), it puts the browser in an
endless loop.

The reason is that the method `stream.next()` declares to either return
a string value or `void` (=`undefined`), but the code checks for `null`.
The check is now fixed and another cases where a loose null comparison
was used is adapted as well. Note that a loose null comparison between
null and undefined return equality, but a strict comparison doesn't.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 11/30/23, 08:37

  2. core-ci voted on patch set 1 V +1 11/30/23, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50152

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 11/30/23, 08:43

  4. Andreas Kienast merged patch set 2 11/30/23, 08:43