Review main Merged

82047[TASK] Avoid TSFE->pSetup

Christian Kuhn CR +2 V +2 Hard +400 −415 updated 11/30/23, 12:01

Commit message

Internal property TypoScriptFrontendController->pSetup
contains the TypoScript PAGE TS array of the current
type/typeNum.

FE RequestHandler uses this, but it can be derived directly
from the current type in Request attribute 'routing'
combined with a TS array lookup in Request attribute
'controller.typoscript'.

The patch avoids and removes TSFE->pSetup which resolves
a spaghetti dependency from TypoScriptFrontendController
up into RequestHandler.

Main method processHtmlBasedRenderingSettings() is
streamlined carefully along the way.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Christian Kuhn uploaded patch set 1 11/30/23, 09:10

  2. core-ci voted on patch set 1 V +1 11/30/23, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50153

  3. Christian Kuhn updated the commit message in patch set 2 V +1 11/30/23, 09:28

  4. core-ci voted on patch set 2 V +1 11/30/23, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50157

  5. Christian Kuhn uploaded patch set 3 V +1 11/30/23, 09:35

  6. core-ci voted on patch set 3 V +1 11/30/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50158

  7. Benni Mack voted on patch set 3 CR +1 V +1 11/30/23, 10:11

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 11/30/23, 10:42

  9. Benni Mack voted on patch set 3 CR +2 V +2 11/30/23, 12:01

  10. Benni Mack merged patch set 4 11/30/23, 12:01