Review main Merged

82049[TASK] Clean up workspaces-related code

Benni Mack CR +2 V +2 Hard +49 −514 updated 12/05/23, 09:03

Commit message

This change most notably modifies EXT:workspaces
where various places do not throw a custom exception
anymore due to strict typing in PHP.

In addition, the language file "locallang_mod_user_ws.xlf"
has been removed, as it did not contain any useful labels
anymore, and were part of the "old" (pre-ExtJS) module.

In order to improve code readability, some methods have
been changed or renamed, or legacy comments have been
removed. Constants for internal stages are now used
everywhere.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Benni Mack uploaded patch set 1 11/30/23, 12:17

  2. core-ci voted on patch set 1 V +1 11/30/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50161

  3. Benni Mack updated the commit message in patch set 2 V +1 11/30/23, 12:28

  4. core-ci voted on patch set 2 V +1 11/30/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50163

  5. Jörg Bösche voted on patch set 2 CR +1 11/30/23, 12:38

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 12/01/23, 06:58

  7. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/05/23, 09:03

  8. Anja Leichsenring merged patch set 3 12/05/23, 09:03