Review main Merged

82057[TASK] Omit passing default values to BU::thumbCode()

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 12/04/23, 12:02

Commit message

By using named parameters a couple of unused
parameters can be omitted on calling BU::thumbCode().

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Oli Bartsch uploaded patch set 1 12/01/23, 09:34

  2. core-ci voted on patch set 1 V -1 12/01/23, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50202

  3. Oli Bartsch uploaded patch set 2 V -1 12/01/23, 10:31

  4. core-ci voted on patch set 2 V +1 12/01/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50206

  5. Jochen Roth voted on patch set 2 CR +1 V +1 12/01/23, 13:11

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 12/03/23, 22:39

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 12/04/23, 10:02

  8. Oli Bartsch merged patch set 3 12/04/23, 10:17

  9. Christian Kuhn commented on patch set 3 12/04/23, 12:02

    Unresolved

    Note I'm not a seriously huge fan of named parameters since this creates API to the method parameter names, which can potentially go south rather quickly when refactoring methods. I think core team should come up with a best practice document when/where it's ok to do that, and when we should skip it. I'm fine in this case for now, but we should give some guidelines at hand mid-term.