82061[BUGFIX] Return proper typo3Language key when using locale autodetection
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 68
-
Garvin Hicking uploaded patch set 1 12/01/23, 13:34
-
core-ci voted on patch set 1 V +1 12/01/23, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50209
-
Benni Mack commented on patch set 1 CR -1 12/01/23, 15:28
I think I agree with your Note on your commit message: Let's solve that in that place. IMHO, the correct place to tackle this is LanguageService->readLLfile -
Garvin Hicking uploaded patch set 2
CR -1V +112/01/23, 16:26Apply fix to Locale instantiation for proper failback chain -
Garvin Hicking commented on patch set 2 12/01/23, 16:29
Reply
Ack. This didn't feel right 😄 I've now tracked it down to EXT:login instantiating the Locale class with a missing dependency. So it instantiates Locale with $locale="de_DE" but $dependencies=[]. Other extensions like EXT:bootstrap_package and EXT:indexed_search actually instantiate Locale with $locale="de_DE" and $dependencies=['de']. It would be nice to know why this happens exactly. For now I've jury-rigged it to apply an addition to an empty $dependencies array to fill it with a substring of a locale, which shows languages properly then. -
core-ci voted on patch set 2 V +1 12/01/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50214
-
Benni Mack commented on patch set 2 12/01/23, 16:35
sorry, next try: Please have a look at Locales->getLocaleDependencies() -
Garvin Hicking abandoned the change 12/01/23, 22:48
Abandoned in favor of Bennis own #82065