Review main Merged Breaking

82063[!!!][FEATURE] Add PSR-14 event for manipulating ContentObjectRenderer

Oli Bartsch CR +2 V +2 Hard +289 −17 updated 12/04/23, 17:08

Commit message

This introduces a new PSR-14 event, enabling
extension authors to modify the ContentObjectRenderer
instance, after it has been initialized.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['postInit']
which is therefore now removed.

The hook required implementations to implement
the `ContentObjectPostInitHookInterface`, which
is now deprecated as it's unused due to the
hook removal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1825

  1. Oli Bartsch uploaded patch set 1 12/01/23, 17:12

  2. core-ci voted on patch set 1 V -1 12/01/23, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50216

  3. Oli Bartsch uploaded patch set 2 V -1 12/01/23, 18:00

  4. core-ci voted on patch set 2 V +1 12/01/23, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50217

  5. Jochen Roth voted on patch set 2 CR +1 V +1 12/03/23, 16:14

  6. Oli Bartsch uploaded patch set 3 CR +1 V +1 12/03/23, 16:57

  7. Jochen Roth voted on patch set 3 CR +1 V +1 12/03/23, 16:58

  8. core-ci voted on patch set 3 V +1 12/03/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50289

  9. Stefan Bürk commented on patch set 4 CR +1 V +1 12/03/23, 22:18

    Published edit on patch set 3.
  10. core-ci voted on patch set 4 V +1 12/03/23, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50293

  11. Stefan Bürk uploaded patch set 5 V +1 12/03/23, 22:37

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 12/03/23, 22:38

  13. core-ci voted on patch set 5 V +1 12/03/23, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50294

  14. Benni Mack commented on patch set 5 CR -1 12/04/23, 07:03

    I suggest renaming the event
  15. Oli Bartsch uploaded patch set 6 CR +1 V +1 12/04/23, 10:16

  16. Oli Bartsch uploaded patch set 7 12/04/23, 10:21

  17. core-ci voted on patch set 7 V +1 12/04/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50313

  18. Benni Mack commented on patch set 7 CR -1 12/04/23, 10:32

    AfterContentObjectRendererInitialiazedEvent.php:25

    there is a typo in the class name
  19. Oli Bartsch uploaded patch set 8 CR -1 V +1 12/04/23, 11:02

  20. Oli Bartsch commented on patch set 8 12/04/23, 11:03

    AfterContentObjectRendererInitialiazedEvent.php:25 Reply

    Done
  21. core-ci voted on patch set 8 V +1 12/04/23, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50318

  22. Jochen Roth voted on patch set 8 CR +1 V +1 12/04/23, 11:30

  23. Stefan Bürk voted on patch set 8 CR +1 V +1 12/04/23, 11:48

  24. Oli Bartsch voted on patch set 8 CR +2 V +2 12/04/23, 17:08

  25. Oli Bartsch merged patch set 9 12/04/23, 17:08