82064[FEATURE] Allow record reset in CLI command cleanup:localprocessedfiles
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Guido Schmechel +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Guido Schmechel +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102582-AllowCLICommandCleanupLocalprocessedfilesToResetAllRecords.rstnew+39 −0
- typo3/sysext/lowlevel/Classes/Command/CleanUpLocalProcessedFilesCommand.php4+11 −5
- typo3/sysext/lowlevel/Classes/Service/CleanUpLocalProcessedFilesService.php2+48 −22
- typo3/sysext/lowlevel/Tests/Functional/Clean/CleanUpLocalProcessedFilesTest.php+68 −2
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/DataSet/ReferencedImage.png3newbinary
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/DataSet/ReferencedImage2.pngnewbinary
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/DataSet/sys_file_processedfile.csv+3 −0
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/Modify/allDeleted.csvnew+2 −0
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/Modify/oneDeleted.csv+1 −0
Review log 2026
Show 1 earlier messages
-
Garvin Hicking uploaded patch set 1 12/01/23, 19:15
-
core-ci voted on patch set 1 V -1 12/01/23, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50219
-
Garvin Hicking uploaded patch set 2
V -112/01/23, 19:23CGL -
core-ci voted on patch set 2 V +1 12/01/23, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50220
-
Stefan Bürk commented on patch set 2 12/03/23, 22:37
Some minor remarks, TBH not grasp the full impact yet. Need to re-review this change.Technically, adding a additional command option is a "feature" and thus main only. However, quite unsure of the impact here on a quick view if it "may be okay". TBH - don't checked the implementation in detail yet and need to re-review the patch with a fresh head.CleanUpLocalProcessedFilesCommand.php:53Quite unsure, but I guess I would go more with ``` 'remove-all` or 'clean-all' ``` here instead of "full-reset" - as it's a little bit more understandable by casual integrators and users. What do you think ?CleanUpLocalProcessedFilesService.php:134Please use ```php ->where(...array_values($conditions)) ``` here to avoid accidently key unpacking - and demonstrating `best behaviour`. -
Benni Mack commented on patch set 2 12/04/23, 07:04
CleanUpLocalProcessedFilesCommand.php:53Reply--all :) -
Garvin Hicking commented on patch set 2 12/04/23, 07:36
CleanUpLocalProcessedFilesCommand.php:53Reply> --all :) Sounds good to me, will rework. also I can cut out v12 as a backport, didn't do that intentionally 😅 -
Garvin Hicking uploaded patch set 3
V +112/04/23, 09:39Added tests renamed command -
Garvin Hicking commented on patch set 3 12/04/23, 09:41
I've now renamed the option to "--all". I've decided this should rather be a feature and be documented properly, thus removed the 12.4 backport. Added a feature RST and tests for the new option.CleanUpLocalProcessedFilesCommand.php:53ReplyDoneCleanUpLocalProcessedFilesService.php:134ReplyDone -
core-ci voted on patch set 3 V +1 12/04/23, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50306
-
Garvin Hicking updated the commit message in patch set 4
V +112/21/23, 22:56 -
core-ci voted on patch set 4 V +1 12/21/23, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50886
-
Simon Schaufelberger commented on patch set 4 12/22/23, 00:36
ReferencedImage.pngwhy such a huge image? wouldn't a 10x10px image also be enough? -
Garvin Hicking uploaded patch set 5
V +112/23/23, 16:34Reduced image file size -
core-ci voted on patch set 5 V +1 12/23/23, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50939
-
Garvin Hicking commented on patch set 5 12/23/23, 16:41
ReferencedImage.pngReplyI just used the same existing "NotReferencedImage" in that test actually. I don't find 1700 bytes to be huge, but I get your point and thanks for noticing. I switched the file with a 90byte image now. Maybe you could also comment/review on the patch itself, what do you think of it? BTW: There are many places in the core were large assets reside that could be cleaned up. Out of 33 static images provided in tests, 30 are larger than the 1700 bytes of the image in question: 14928 ./sysext/core/Tests/Unit/Type/Fixture/test.jpg 3334 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.svg.jpg 393450 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.bmp.jpg 4301 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.pdf.jpg 3670 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.tif.jpg 3000 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.jpg 1778 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.webp.jpg 3009 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.png.jpg 603258 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.ps.jpg 603232 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.eps.jpg 3462 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.fax.jpg 129076 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.ai.jpg 166843 ./sysext/frontend/Tests/Functional/Fixtures/Images/team-t3board10.jpg 39037 ./sysext/frontend/Tests/Functional/Fixtures/Images/kasper-skarhoj1.jpg 5565 ./sysext/impexp/Tests/Functional/Fixtures/FileAssertions/typo3_image2_01.jpg 7958 ./sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload/typo3_image2.jpg 5565 ./sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload/typo3_image3.jpg 7425 ./sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload/typo3_image5.jpg 8266 ./sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/_processed_/csm_typo3_image2_5c2670fd59.jpg 22835 ./sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/ImageViewHelperTest.jpg 166023 ./sysext/core/Tests/Unit/Type/Fixture/test.png 3009 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.png 3000 ./sysext/core/Tests/Functional/Imaging/Fixtures/file.jpg.png 1936 ./sysext/core/Tests/Functional/DataHandling/FlexformIrre/Fixtures/fileadmin/typo3-logo.png I didn't want to mix changing these inside this patch, but if you'd like to create one, I'd be +1 for adjusting these in all cases, I think this is a fair point. :-) -
Garvin Hicking commented on patch set 5 12/23/23, 16:42
ReferencedImage.pngReplyDone -
Stefan Bürk commented on patch set 5 CR +1 V +1 12/26/23, 11:03
Reply
Done -
Guido Schmechel commented on patch set 5 12/28/23, 20:10
full-reset -> all -
Garvin Hicking updated the commit message in patch set 6
CR +1V +112/29/23, 11:33 -
Garvin Hicking commented on patch set 6 12/29/23, 11:34
Reply
Done -
core-ci voted on patch set 6 V +1 12/29/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50995
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 01/03/24, 06:48
-
Guido Schmechel voted on patch set 6 CR +1 V +1 01/04/24, 11:59
-
Stefan Bürk voted on patch set 6 CR +2 V +2 01/04/24, 14:12
-
Stefan Bürk merged patch set 7 01/04/24, 14:12