82065[BUGFIX] Use locale dependencies in Extbase LocalizationUtility
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Localization/Locale.php3+4 −0
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+3 −1
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/Resources/Private/Language/de_CH.locallang.xlfnew+11 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php+71 −7
Review log 1012
-
Benni Mack uploaded patch set 1 12/01/23, 22:15
-
core-ci voted on patch set 1 V +1 12/01/23, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50226
-
Garvin Hicking commented on patch set 1 CR +1 12/01/23, 22:32
looking great, from pure reading this should work out, thanks. If not merged by monday, I'll test. -
Oliver Klee commented on patch set 1 12/02/23, 08:56
Locale.php:67Is this a warning to not use the constructor directly? If so, I'd suggest the wording "Instead of creating instances directly, it is recommended …" to make this more explicit to the reader/developer. -
Benni Mack commented on patch set 2
CR +1V +112/03/23, 19:35Published edit on patch set 1. -
Benni Mack commented on patch set 2 12/03/23, 19:35
Locale.php:67ReplyPlease check my updated comment -
core-ci voted on patch set 2 V +1 12/03/23, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50291
-
Oliver Klee commented on patch set 2 12/03/23, 20:19
Locale.php:67ReplyPerfect! Thanks! -
Stefan Bürk voted on patch set 2 CR +1 V +1 12/03/23, 22:14
-
Garvin Hicking commented on patch set 2 CR +1 V +1 12/04/23, 08:18
Now tested, fixes my issue, thanks for providing the better way to solve it. -
Benni Mack voted on patch set 2 CR +2 V +2 12/04/23, 08:42
-
Benni Mack merged patch set 3 12/04/23, 08:42