Review main Merged Breaking

82066[!!!][TASK] Simplify adminPanel forceTemplateParsing

Christian Kuhn CR +2 V +2 Normal +59 −97 updated 12/03/23, 09:17

Commit message

EXT:adminpanel class TypoScriptWaterfall sets both
'no_cache' and the typoscript context aspect
'forcedTemplateParsing' to true when the admin
panel related option 'Force template parsing' is
enabled.

This setting is "on" by either using the admin panel
FE interface (which stores settings in BE user "uc"),
or using BE user UserTsConfig
admPanel.override.tsdebug.forceTemplateParsing = 1.

All consumers of the forcedTemplateParsing aspect
property (namely in TypoScriptFrontendController)
always check both 'no_cache' and 'forcedTemplateParsing',
so that's duplicate information.

The patch removes the 'typoscript' context aspect
altogether and simplifies consumers to rely on the
'no_cache' flag only.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 910

  1. Christian Kuhn uploaded patch set 1 12/02/23, 10:10

  2. core-ci voted on patch set 1 V +1 12/02/23, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50234

  3. Oliver Klee voted on patch set 1 CR +1 12/02/23, 11:07

  4. Stefan Bürk voted on patch set 1 CR +1 12/02/23, 13:10

  5. Stefan Bürk voted on patch set 1 V +1 12/02/23, 13:11

  6. Anja Leichsenring voted on patch set 1 CR +1 V +1 12/02/23, 13:12

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 12/02/23, 13:15

  8. Christian Kuhn merged patch set 2 12/02/23, 13:15

  9. Simon Schaufelberger commented on patch set 2 12/02/23, 13:56

    Breaking-102583-RemovedContextAspectTyposcript.rst:23

    will
  10. Christian Kuhn commented on patch set 2 12/03/23, 09:17

    Breaking-102583-RemovedContextAspectTyposcript.rst:23 Reply

    thx. will update with an upcoming patch as drive-by.