82069[FEATURE] Introduce sortable Doctrine DBAL middleware registration
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 11
- typo3/sysext/adminpanel/ext_localconf.php+6 −1
- typo3/sysext/core/Classes/Database/ConnectionPool.php+74 −13
- typo3/sysext/core/Classes/Database/DriverMiddlewareService.phpnew+85 −0
- typo3/sysext/core/Classes/ServiceProvider.php+8 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+3 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102586-DeprecateSimpleStringConnectionDriverMiddlewareRegistration.rstnew+81 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst+21 −10
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102586-IntroduceSortableDoctrineDBALMiddlewareRegistration.rstnew+89 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ConnectionDriverMiddlewaresProvider.phpnew+71 −0
- typo3/sysext/lowlevel/Configuration/Services.yaml+8 −0
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+3 −0
Review log 1421
-
Stefan Bürk uploaded patch set 1 12/02/23, 20:08
-
Stefan Bürk wrote 12/02/23, 20:09
Topic set to doctrine-dbal -
Stefan Bürk uploaded patch set 2 12/02/23, 20:10
-
core-ci voted on patch set 1 V +1 12/02/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50252
-
core-ci voted on patch set 2 V +1 12/02/23, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50253
-
Stefan Bürk uploaded patch set 3
V +112/02/23, 22:43 -
core-ci voted on patch set 3 V +1 12/02/23, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50254
-
Stefan Bürk uploaded patch set 4 12/03/23, 02:46
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 4 V +1 12/03/23, 02:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50261
-
core-ci commented on patch set 4 12/03/23, 04:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50266
-
Stefan Bürk uploaded patch set 5
V +112/03/23, 12:21 -
core-ci voted on patch set 5 V +1 12/03/23, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50276
-
Oliver Klee voted on patch set 5 V +1 12/03/23, 14:36
-
Benni Mack commented on patch set 5 CR +1 V +1 12/06/23, 09:38
As mentioned, I suggest to move the middleware registration into custom "middleware stacks" which is breaking. Basically a new registration: Configuration/DoctrineMiddlewares.php where you have a "global" middleware, but also any arbritrary name such as "benni", as keyword. In TYPO3_CONF_VARS. A connection can then define which middleware to use. Why? Since we use DependencyOrderingservice, I would like to have this ordering within the DI setup, and not on every request. However, this can be dealt with separately, so this is fine for the time being. -
Benni Mack updated the commit message in patch set 6
CR +1V +112/08/23, 06:57 -
Benni Mack voted on patch set 6 CR +1 V +1 12/08/23, 06:57
-
core-ci voted on patch set 6 V +1 12/08/23, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50471
-
Oliver Klee voted on patch set 6 V +1 12/08/23, 09:47
-
Christian Kuhn voted on patch set 6 CR +1 V +1 12/08/23, 10:18
-
Stefan Bürk voted on patch set 6 CR +2 V +2 12/08/23, 12:30
-
Stefan Bürk merged patch set 7 12/08/23, 12:30