82070[FEATURE] Introduce driver middleware `UsableForConnectionInterface`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 4
Files 5
- typo3/sysext/core/Classes/Database/Middleware/UsableForConnectionInterface.phpnew+29 −0
- typo3/sysext/core/Classes/Database/ConnectionPool.php8+26 −16
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst9new+123 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DriverMiddlewares/DropForConnectionNamedSecondTestDriverMiddleware.phpnew+36 −0
- typo3/sysext/core/Tests/Functional/Database/ConnectionPoolTest.phpnew+55 −0
Review log 3856
Show 2231 earlier messages
-
Stefan Bürk uploaded patch set 1 12/03/23, 01:18
-
Stefan Bürk wrote 12/03/23, 01:20
Topic set to doctrine-dbal -
Stefan Bürk updated the commit message in patch set 2 12/03/23, 01:24
-
core-ci voted on patch set 1 V +1 12/03/23, 01:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50256
-
core-ci voted on patch set 2 V +1 12/03/23, 01:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50257
-
Stefan Bürk uploaded patch set 3
V +112/03/23, 02:46 -
core-ci voted on patch set 3 V +1 12/03/23, 02:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50262
-
core-ci commented on patch set 3 12/03/23, 04:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50267
-
Stefan Bürk rebased onto patch set 4
V +112/03/23, 12:21 -
core-ci voted on patch set 4 V +1 12/03/23, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50277
-
Stefan Bürk rebased onto patch set 5
V +112/08/23, 12:35 -
core-ci voted on patch set 5 V +1 12/08/23, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50494
-
Oliver Klee voted on patch set 5 V +1 12/09/23, 10:20
-
Benni Mack voted on patch set 5 CR +1 V +1 12/11/23, 07:02
-
Benni Mack commented on patch set 5 12/11/23, 07:03
Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:26"id a middleware"Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:29remove "provides now" => "now provides" -
Stefan Bürk commented on patch set 5 12/14/23, 07:51
Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:29Replyremove or replace ? Assumed "replace" now ... -
Stefan Bürk uploaded patch set 6
CR +1V +112/14/23, 07:51 -
Stefan Bürk commented on patch set 6 12/14/23, 07:51
Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:26ReplyDoneFeature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:29ReplyDone -
core-ci voted on patch set 6 V +1 12/14/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50635
-
Benni Mack voted on patch set 6 CR +1 V +1 12/14/23, 08:03
-
Nikita Hovratov commented on patch set 6 CR -1 12/14/23, 09:47
ConnectionPool.php:271This huge array_filter block is so hard to read. I would suggest to keep it simple and use a foreach loop instead and collect all "usable" $driverMiddlewares in a separate array. -
Stefan Bürk commented on patch set 6 12/14/23, 10:05
ConnectionPool.php:271ReplyUsing foreach would not make it more readable - it would increase the "complexity". Using `array_filter` to filter a array is a good aproach. Using `match` is a easy way, but as a compromis - we could switch to a simple if - construct and a default return instead of the match - maybe that makes it more readable for you. -
Oliver Klee commented on patch set 6 V +1 12/14/23, 10:11
ConnectionPool.php:271ReplyChiming on with my "readability hat" on. ;-) Yes, an `if` instead of the `match` would make the code easier to read for me as well. -
Stefan Bürk uploaded patch set 7
CR +1V +112/14/23, 10:12 -
core-ci voted on patch set 7 V +1 12/14/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50646
-
Nikita Hovratov commented on patch set 7 12/14/23, 10:22
ConnectionPool.php:271ReplyDone -
Nikita Hovratov commented on patch set 7 CR -1 12/14/23, 10:23
ConnectionPool.php:271The result of array_filter must be assigned to $driverMiddlewares. Btw is it possible to have a test for the filtering? -
Stefan Bürk uploaded patch set 8
CR -1V +112/14/23, 10:46 -
Stefan Bürk commented on patch set 8 CR -1 12/14/23, 10:47
will try to come up with test on the weekend - do not have time before -
core-ci voted on patch set 8 V +1 12/14/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50648
-
Stefan Bürk uploaded patch set 9
CR -1V +101/06/24, 13:21
-
Stefan Bürk commented on patch set 9 01/06/24, 13:21
ConnectionPool.php:271ReplyDone -
Stefan Bürk uploaded patch set 10 01/06/24, 13:23
-
core-ci voted on patch set 9 V -1 01/06/24, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51160
-
Stefan Bürk uploaded patch set 11 01/06/24, 13:26
-
core-ci voted on patch set 11 V +1 01/06/24, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51163
-
core-ci voted on patch set 11 V -1 01/06/24, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51164
-
core-ci voted on patch set 11 V +1 01/06/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51164
-
Oliver Klee commented on patch set 11 V +1 01/06/24, 15:28
ConnectionPool.php:271Let's have native type declarations here: ```php $driverMiddlewares = array_filter($driverMiddlewares, static function (array $middleware) use ($connectionName, $connectionParams): bool { ``` -
Chris Müller commented on patch set 11 01/06/24, 17:02
Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:20Please remove the starting `_` from the reference. The `_` is part of the anchor definition, not of the reference itself. Also the first one misses a closing bracket `>`.Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:23registerd -> registered -
Stefan Bürk uploaded patch set 12
V +101/08/24, 09:07 -
Stefan Bürk commented on patch set 12 01/08/24, 09:07
ConnectionPool.php:271ReplyDoneFeature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:20ReplyDoneFeature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst:23ReplyDone -
core-ci voted on patch set 12 V +1 01/08/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51201
-
Stefan Bürk rebased onto patch set 13
V +101/08/24, 10:32 -
Stefan Bürk uploaded patch set 14 01/08/24, 10:36
-
core-ci voted on patch set 13 V +1 01/08/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51209
-
core-ci voted on patch set 14 V +1 01/08/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51213
-
Stefan Bürk uploaded patch set 15 01/08/24, 10:58
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 15 V +1 01/08/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51215
-
Christian Kuhn voted on patch set 15 CR +1 V +1 01/08/24, 12:24
-
Benni Mack commented on patch set 16
CR +1V +101/08/24, 12:35Published edit on patch set 15. -
Benni Mack voted on patch set 16 CR +1 V +1 01/08/24, 12:35
-
core-ci voted on patch set 16 V +1 01/08/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51231
-
Christian Kuhn voted on patch set 16 CR +1 V +1 01/08/24, 12:41
-
Stefan Bürk voted on patch set 16 CR +2 V +2 01/08/24, 12:42
-
Stefan Bürk merged patch set 17 01/08/24, 12:42