82071[TASK] Implement PDO DriverResult as `doctrine/dbal driver middleware`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 6
- Task #102588Implement PDO DriverResult as `doctrine/dbal driver middleware`
- Feature #102587Introduce driver middleware `UsableForConnectionInterface`
- Feature #102586Introduce sortable Doctrine DBAL middleware registration
- Feature #102496Introduce global Doctrine DBAL driver middlewares
- Feature #100089Introduce Doctrine DBAL v3 driver middlewares
- Task #96287Update dependency: Doctrine DBAL 3.2
Files 21
- typo3/sysext/core/Classes/Database/Driver/PDOMySql/Driver.phpdeleted+0 −82
- typo3/sysext/core/Classes/Database/Driver/PDOPgSql/Driver.phpdeleted+0 −113
- typo3/sysext/core/Classes/Database/Driver/PDOSqlite/Driver.phpdeleted+0 −83
- typo3/sysext/core/Classes/Database/Driver/CustomPdoResultDriverDecorator.phpnew+33 −0
- typo3/sysext/core/Classes/Database/Driver/CustomPlatformDriverDecorator.php+1 −1
- typo3/sysext/core/Classes/Database/Driver/DriverConnection.php+6 −75
- typo3/sysext/core/Classes/Database/Driver/DriverResult.php+12 −75
- typo3/sysext/core/Classes/Database/Driver/DriverStatement.php4+4 −103
- typo3/sysext/core/Classes/Database/Middleware/CustomPdoDriverResultMiddleware.php2new+55 −0
- typo3/sysext/core/Classes/Database/Middleware/CustomPlatformDriverMiddleware.php+5 −4
- typo3/sysext/core/Classes/Database/Middleware/UsableForConnectionInterface.php1+12 −0
- typo3/sysext/core/Classes/Database/ConnectionPool.php2+3 −35
- typo3/sysext/core/Classes/Database/DriverMiddlewareService.php+1 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php+9 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst10+8 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102586-IntroduceSortableDoctrineDBALMiddlewareRegistration.rst+9 −7
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102587-IntroduceDriverMiddlewareInterfaceUsableForConnectionInterface.rst+11 −0
- typo3/sysext/core/Tests/Functional/Database/Middleware/CustomPdoDriverResultMiddlewareTest.phpnew+110 −0
- typo3/sysext/core/Tests/Functional/Database/Middleware/CustomPlatformDriverMiddlewareTest.phpnew+66 −0
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck.php+18 −15
Review log 4363
Show 2438 earlier messages
-
Stefan Bürk uploaded patch set 1 12/03/23, 02:04
-
Stefan Bürk wrote 12/03/23, 02:05
Topic set to doctrine-dbal -
core-ci voted on patch set 1 V -1 12/03/23, 02:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50259
-
Stefan Bürk uploaded patch set 2
V -112/03/23, 02:54 -
core-ci voted on patch set 2 V +1 12/03/23, 03:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50263
-
core-ci voted on patch set 2 V -1 12/03/23, 04:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50268
-
core-ci voted on patch set 2 V +1 12/03/23, 04:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50268
-
Stefan Bürk rebased onto patch set 3
V +112/03/23, 12:21 -
core-ci voted on patch set 3 V +1 12/03/23, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50278
-
Stefan Bürk rebased onto patch set 4
V +112/08/23, 12:35 -
core-ci voted on patch set 4 V +1 12/08/23, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50495
-
Stefan Bürk rebased onto patch set 5
V +112/14/23, 07:52 -
core-ci voted on patch set 5 V +1 12/14/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50636
-
Stefan Bürk rebased onto patch set 6
V +101/06/24, 13:24 -
Stefan Bürk rebased onto patch set 7 01/06/24, 13:35
-
core-ci voted on patch set 7 V +1 01/06/24, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51165
-
Stefan Bürk uploaded patch set 8
V +101/06/24, 14:15 -
core-ci voted on patch set 8 V -1 01/06/24, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51166
-
Chris Müller commented on patch set 8 01/06/24, 16:53
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56Hmm, this can become quite problematic when adding further Core middlewares in the future, as extension authors have to adapt their configuration accordingly. Just a thought: Maybe we can introduce some kind of a "meta" driver middleware which does nothing but is added after the Core one's and extension authors can rely on that one. So only one "after" is needed. What do you think? -
Stefan Bürk rebased onto patch set 9
V -101/08/24, 09:43 -
Stefan Bürk commented on patch set 9 01/08/24, 09:45
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56Replynot a fan of a dummy fake middleware here which does nothing. but will think about it, however requires to have the ancestor patch merged first. -
core-ci voted on patch set 9 V -1 01/08/24, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51208
-
Stefan Bürk commented on patch set 9 01/08/24, 09:50
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyThe point is that these two are mostly relevent. I guess core middlewares comming on top are most likely "optional". For example the adminpanel middleware is a) connection based one and b) optional no one have to relay on. These two middleware provides basic things, one for everything the second for some pdo drivers - which should be there first. -
Stefan Bürk commented on patch set 9 01/08/24, 09:55
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyWill add a Noop middleware and use it as marker. -
Stefan Bürk uploaded patch set 10
V -101/08/24, 10:32 -
Stefan Bürk commented on patch set 10 01/08/24, 10:33
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyIntroduced a marker middleware now. Fine for you that way ? -
Stefan Bürk rebased onto patch set 11 01/08/24, 10:36
-
core-ci voted on patch set 10 V -1 01/08/24, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51210
-
core-ci voted on patch set 11 V -1 01/08/24, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51214
-
Stefan Bürk uploaded patch set 12
V -101/08/24, 10:58 -
core-ci voted on patch set 12 V +1 01/08/24, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51216
-
Benni Mack commented on patch set 12 01/08/24, 12:37
DriverStatement.php:30do we need this still? The comment? Or can we drop this with Doctrine DBAL 4 requirement? -
Stefan Bürk commented on patch set 12 CR -1 01/08/24, 13:39
going to add some comments ...DriverStatement.php:30ReplyYes, otherwise we could not return the custom `DriverResult->mapResourceToString()` - which provides the "fix" the whole thing is about. -
Stefan Bürk commented on patch set 12 01/08/24, 13:39
DriverStatement.php:30ReplyArgx, misread - you meant the comment. Nope, will remove it. -
Stefan Bürk uploaded patch set 13
CR -1V +101/08/24, 14:34 -
Stefan Bürk commented on patch set 13 01/08/24, 14:34
DriverStatement.php:30ReplyDone -
Stefan Bürk commented on patch set 13 01/08/24, 14:36
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyDone -
core-ci voted on patch set 13 V +1 01/08/24, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51247
-
Benni Mack commented on patch set 13 01/08/24, 14:43
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyI do not see the benefit of having the Noop middleware. Why? Driver middlewares are not as populated as e.g. HTTP middlewares for Frontend or Backend. I only have one middleware to deal with a multi-node cluster without a round-robin LB in a galera setup. In this case, I know carefully what I would need to do and happy to adapt during TYPO3 updates. I also would like to deep-dive (once we use Doctrine DBAL v4) to get rid of one of the middlewares we ship in core, making this feature a cool but very special case. -
Stefan Bürk uploaded patch set 14
V +101/08/24, 15:18 -
Stefan Bürk uploaded patch set 15 01/08/24, 15:21
-
core-ci voted on patch set 14 V +1 01/08/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51254
-
Stefan Bürk commented on patch set 15 01/08/24, 15:27
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyReverted the `Noop`/Marker driver middleware. -
core-ci voted on patch set 15 V +1 01/08/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51256
-
Benni Mack commented on patch set 15 01/08/24, 15:59
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyChris, fine for you? -
Chris Müller commented on patch set 15 01/08/24, 17:50
Feature-102496-IntroduceGlobalDoctrineDBALDriverMiddlewares.rst:56ReplyAcknowledged -
Oliver Klee voted on patch set 15 V +1 01/08/24, 18:08
-
Benni Mack updated the commit message in patch set 16
V +101/08/24, 20:08 -
Benni Mack commented on patch set 17 01/08/24, 20:09
Published edit on patch set 16. -
Benni Mack voted on patch set 17 CR +1 V +1 01/08/24, 20:09
-
core-ci voted on patch set 16 V +1 01/08/24, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51283
-
core-ci voted on patch set 17 V +1 01/08/24, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51284
-
Stefan Bürk commented on patch set 18
CR +1V +101/09/24, 03:25Published edit on patch set 17. -
core-ci voted on patch set 18 V +1 01/09/24, 03:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51296
-
Benni Mack voted on patch set 18 CR +1 V +1 01/09/24, 06:34
-
Christian Kuhn commented on patch set 18 01/09/24, 09:15
ConnectionPool.php:208where is this used?CustomPdoDriverResultMiddleware.php:26this could have a comment on why we need it and why the pdo_ drivers are so special / why mysql is unspecial or the other way round.UsableForConnectionInterface.php:33thx! -
Stefan Bürk uploaded patch set 19
CR +1V +101/09/24, 10:16 -
Stefan Bürk commented on patch set 19 01/09/24, 10:17
ConnectionPool.php:208ReplyMoved to the corresponding provider like discussed.CustomPdoDriverResultMiddleware.php:26ReplyDone -
core-ci voted on patch set 19 V +1 01/09/24, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51318
-
Christian Kuhn voted on patch set 19 CR +1 V +1 01/09/24, 10:54
-
Benni Mack voted on patch set 19 CR +1 V +1 01/09/24, 10:55
-
Stefan Bürk voted on patch set 19 CR +2 V +2 01/09/24, 10:56
-
Stefan Bürk merged patch set 20 01/09/24, 10:56