Review main Merged

82072[TASK] Remove superflous code from `CustomPlatformDriverDecorator`

Stefan Bürk CR +2 V +2 Easy +4 −31 updated 12/14/23, 11:52

Commit message

With #102402 the deprecated `doctrine/event-manager` has been
mitigated by using a global doctrine dbal driver middleware.

Therefore, the driver decorater `CustomPlatformDriverDecorator`
has been added providing a lot of methods to full-fill the
interface requirements.

This change removes unneeded code by extending from the
`\Doctrine\DBAL\Driver\Middleware\AbstractDriverMiddleware`
for the `CustomPlatformDriverDecorator` implementation.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1421

  1. Stefan Bürk uploaded patch set 1 12/03/23, 02:25

  2. core-ci voted on patch set 1 V -1 12/03/23, 02:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50260

  3. Stefan Bürk rebased onto patch set 2 V -1 12/03/23, 02:55

  4. core-ci voted on patch set 2 V +1 12/03/23, 03:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50264

  5. core-ci commented on patch set 2 12/03/23, 04:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50269

  6. Stefan Bürk rebased onto patch set 3 V +1 12/03/23, 12:21

  7. core-ci voted on patch set 3 V +1 12/03/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50279

  8. Stefan Bürk updated the commit message in patch set 4 V +1 12/03/23, 12:47

  9. core-ci voted on patch set 4 V +1 12/03/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50281

  10. Oliver Klee voted on patch set 4 CR +1 V +1 12/03/23, 14:34

  11. Stefan Bürk commented on patch set 4 CR -1 12/03/23, 14:41

    chain changes needs to be merged first (to be safe)
  12. Stefan Bürk wrote 12/03/23, 15:57

    Topic set to doctrine-dbal
  13. Stefan Bürk rebased onto patch set 5 CR +1 V +1 12/08/23, 12:35

  14. core-ci voted on patch set 5 V +1 12/08/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50496

  15. Oliver Klee voted on patch set 5 CR +1 V +1 12/09/23, 10:20

  16. Stefan Bürk rebased onto patch set 6 CR +1 V +1 12/14/23, 07:52

  17. core-ci voted on patch set 6 V +1 12/14/23, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50637

  18. Oliver Klee voted on patch set 6 CR +1 V +1 12/14/23, 10:31

  19. Christian Kuhn voted on patch set 6 CR +1 V +1 12/14/23, 11:43

  20. Stefan Bürk voted on patch set 6 CR +2 V +2 12/14/23, 11:52

  21. Stefan Bürk merged patch set 7 12/14/23, 11:52