82073[FEATURE] FE cache information request attribute
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Sascha Nowak +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 25
- typo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php+3 −10
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+11 −11
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php+4 −1
- typo3/sysext/adminpanel/Classes/Modules/CacheModule.php+4 −1
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+8 −7
- typo3/sysext/adminpanel/Resources/Private/Templates/Modules/Info/General.html+4 −0
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+3 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst+1 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102628-CacheInstructionMiddleware.rst2new+42 −0
- typo3/sysext/frontend/Classes/Cache/CacheInstruction.phpnew+71 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+49 −69
- typo3/sysext/frontend/Classes/Event/AfterCacheableContentIsGeneratedEvent.php+1 −1
- typo3/sysext/frontend/Classes/Event/AfterCachedPageIsPersistedEvent.php+5 −5
- typo3/sysext/frontend/Classes/Event/ShouldUseCachedPageDataIfAvailableEvent.php+1 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php+5 −2
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+21 −33
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+19 −13
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+4 −1
Show 5 more files
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+8 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/PageArgumentValidatorTest.php+6 −15
- typo3/sysext/redirects/Classes/Service/RedirectService.php+3 −0
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php2+5 −9
- .phpstorm.meta.php+2 −0
Review log 2333
Show 58 earlier messages
-
Christian Kuhn uploaded patch set 1 12/03/23, 09:51
-
core-ci voted on patch set 1 V +1 12/03/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50270
-
Christian Kuhn uploaded patch set 2
V +112/03/23, 11:27 -
core-ci voted on patch set 2 V +1 12/03/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50274
-
Christian Kuhn uploaded patch set 3
V +112/03/23, 12:12 -
core-ci voted on patch set 3 V +1 12/03/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50275
-
Benni Mack commented on patch set 3 12/04/23, 11:53
-
Christian Kuhn uploaded patch set 4
V +112/07/23, 15:19
-
Christian Kuhn commented on patch set 4 12/07/23, 15:23
CacheInformationRequestAttribute.php:23ReplyDone -
core-ci voted on patch set 4 V +1 12/07/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50459
-
Christian Kuhn uploaded patch set 5
V +112/07/23, 15:46 -
Christian Kuhn commented on patch set 5 12/07/23, 15:47
CacheInformationRequestAttribute.php:23Replynote the page cache identifier (which currently runs under the awful name "newHash") will most likely be part of that attribute as well, and only used by a different attribute later thaht -
core-ci voted on patch set 5 V +1 12/07/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50461
-
Christian Kuhn uploaded patch set 6
V +112/07/23, 16:10 -
core-ci voted on patch set 6 V +1 12/07/23, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50462
-
Christian Kuhn uploaded patch set 7
V +112/07/23, 16:17 -
Christian Kuhn commented on patch set 7 12/07/23, 16:18
benni requested renaming from CacheInstructionRequestAttribute to CacheInstruction. -
core-ci voted on patch set 7 V +1 12/07/23, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50463
-
Christian Kuhn uploaded patch set 8
V +112/08/23, 10:45 -
Christian Kuhn updated the commit message in patch set 9 12/08/23, 10:46
-
core-ci voted on patch set 9 V +1 12/08/23, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50486
-
core-ci voted on patch set 8 V +1 12/08/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50485
-
Sascha Nowak commented on patch set 9 CR +1 12/08/23, 11:23
Feature-102628-CacheInstructionMiddleware.rst:25Could we add an Example here how to use it. Personally I as a developer was searching for there files and love to copy an example as a starting point: $cacheInstruction = $request->getAttribute('frontend.cache.instruction', new CacheInstruction()); $cacheInstruction->disableCache('EXT:mxext: Add reason here why you disables the cache.'); -
Christian Kuhn uploaded patch set 10
CR +1V +112/08/23, 11:54 -
Christian Kuhn commented on patch set 9 12/08/23, 11:54
Feature-102628-CacheInstructionMiddleware.rst:25ReplyDone -
Sascha Nowak voted on patch set 10 CR +1 12/08/23, 11:57
-
Benni Mack voted on patch set 10 CR +1 V +1 12/08/23, 11:58
-
core-ci voted on patch set 10 V +1 12/08/23, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50492
-
Oli Bartsch voted on patch set 10 CR +1 V +1 12/08/23, 16:15
-
Christian Kuhn voted on patch set 10 CR +2 V +2 12/09/23, 10:16
-
Christian Kuhn merged patch set 11 12/09/23, 10:16
-
Simon Schaufelberger commented on patch set 11 12/09/23, 11:04
WorkspacePreview.php:122to be consistent, "Ext" should be used like all other other places. -
Christian Kuhn commented on patch set 11 12/10/23, 07:40
WorkspacePreview.php:122Replychanging as drive-by with another patch.
CacheInformationRequestAttribute.php:23