82076[TASK] Mitigate deprecated doctrine `SchemaDiff` methods
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 14
- typo3/sysext/core/Classes/Database/Platform/MariaDB1027Platform.php+1 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDB1043Platform.php+1 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDB1052Platform.php+1 −0
- typo3/sysext/core/Classes/Database/Platform/MariaDBPlatform.php+1 −0
- typo3/sysext/core/Classes/Database/Platform/MySQL57Platform.php+1 −0
- typo3/sysext/core/Classes/Database/Platform/MySQL80Platform.php+1 −0
- typo3/sysext/core/Classes/Database/Platform/MySQLPlatform.php+1 −0
- typo3/sysext/core/Classes/Database/Platform/PlatformSaveAlterSchemaSQLTrait.phpnew+56 −0
- typo3/sysext/core/Classes/Database/Platform/PostgreSQL94Platform.php+2 −0
- typo3/sysext/core/Classes/Database/Platform/PostgreSQL100Platform.php+2 −0
- typo3/sysext/core/Classes/Database/Platform/PostgreSQLPlatform.php+2 −0
- typo3/sysext/core/Classes/Database/Platform/SQLitePlatform.php+2 −0
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+19 −15
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+2 −3
Review log 1114
-
Stefan Bürk uploaded patch set 1 12/03/23, 15:29
-
core-ci voted on patch set 1 V +1 12/03/23, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50282
-
Stefan Bürk wrote 12/03/23, 15:57
Topic set to doctrine-dbal -
Oliver Klee commented on patch set 1 12/03/23, 16:30
I don't quite understand the name of the new temporary method. Maybe I can come up with a more communicative name after I have understood the current name. It is about "saving" (i.e., storing) something, or is it about something "safe" (i.e., not risky)? -
Stefan Bürk commented on patch set 1 12/03/23, 16:51
Reply
Basically it's more about beeing "not risky" (safe). The naming is taken from the old doctrine naming, and I would keep that for now. Both are not really usefull here. There it was more for "save sql in a safe state". It's a pure internal implementation for now and the plan is to refactor this in some way, but TBH not a final plan on how yet. Decided to go with this to have this prepartion unblocked for the Doctrine DBAL 4 upgrade and deal with a generic refactoring later. Doctrine DBAL 4 will introduce breaking stuff, so we need to have it in until 13.0 - the refactoring of the internal classes can be done in the further 13.x development time frame as the database analyser stack is internal. See docblock from the deprecated `toSaveSql()` method: ```php /** * The to save sql mode ensures that the following things don't happen: * * 1. Tables are deleted * 2. Sequences are deleted * 3. Foreign Keys which reference tables that would otherwise be deleted. * * This way it is ensured that assets are deleted which might not be relevant to the metadata schema at all. * * @deprecated * * @return list<string> */ public function toSaveSql(AbstractPlatform $platform) ``` Therefore, I will keep the nameing as a endless "naming discussion" block would break the overall timeschedule for nothing. -
Oliver Klee commented on patch set 1 12/03/23, 20:18
Reply
Ack - thanks for the explanation! -
Stefan Bürk rebased onto patch set 2
V +112/08/23, 12:35 -
core-ci voted on patch set 2 V +1 12/08/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50497
-
Stefan Bürk rebased onto patch set 3
V +112/14/23, 07:52 -
core-ci voted on patch set 3 V +1 12/14/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50638
-
Oliver Klee voted on patch set 3 CR +1 V +1 12/14/23, 12:16
-
Christian Kuhn voted on patch set 3 CR +1 V +1 12/18/23, 11:15
-
Stefan Bürk voted on patch set 3 CR +2 V +2 12/18/23, 11:26
-
Stefan Bürk merged patch set 4 12/18/23, 11:27