Review main Merged Breaking

82078[!!!][TASK] Raise minimal MySQL server version

Stefan Bürk CR -1 V +2 Easy +11 −14 updated 12/05/23, 12:28

Commit message

Albeit creating a index for json-field array
values is not supported by MariaDB and SQLite,
the MySQL server version is raised to `8.0.17`
which adds support for a multi-value index.

Even if there is no ETA when `MariaDB` will
introduce a similar feature, this allows to
add a "json" based caching backend as a 3rd
party extension for MySQL DBMS, but have the
minimal version ensured.

Review

  • Code review CR -1 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk -1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1519

  1. Stefan Bürk uploaded patch set 1 12/03/23, 16:37

  2. Stefan Bürk updated the commit message in patch set 2 12/03/23, 16:39

  3. Stefan Bürk wrote 12/03/23, 16:39

    Topic set to Database API
  4. Oliver Klee updated the commit message in patch set 3 12/03/23, 16:41

  5. core-ci voted on patch set 1 V +1 12/03/23, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50285

  6. Oliver Klee voted on patch set 3 CR +1 V +1 12/03/23, 16:44

  7. core-ci voted on patch set 2 V +1 12/03/23, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50287

  8. core-ci voted on patch set 3 V +1 12/03/23, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50288

  9. Chris Müller commented on patch set 3 12/03/23, 17:51

    Breaking-102518-DatabaseEngineVersionRequirements.rst:10

    This will be rendered as "See 102518 See 102594". I suggest to write "See 102518 and 102594"

    Breaking-102518-DatabaseEngineVersionRequirements.rst:31

    MariaDB -> MariaDB/MySQL
  10. Stefan Bürk uploaded patch set 4 CR +1 V +1 12/03/23, 21:26

  11. Stefan Bürk commented on patch set 4 12/03/23, 21:26

    Breaking-102518-DatabaseEngineVersionRequirements.rst:10 Reply

    Done

    Breaking-102518-DatabaseEngineVersionRequirements.rst:31 Reply

    Done
  12. core-ci voted on patch set 4 V +1 12/03/23, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50292

  13. Oliver Klee voted on patch set 4 CR +1 V +1 12/03/23, 21:38

  14. Christian Kuhn voted on patch set 4 CR +1 V +1 12/04/23, 15:35

  15. Stefan Bürk commented on patch set 4 CR -1 12/04/23, 15:40

    temp -1 - I want to talk with Benni about the raise beforehand.
  16. Benni Mack voted on patch set 4 CR +1 V +1 12/05/23, 12:24

  17. Benni Mack commented on patch set 4 V 0 CR -2 12/05/23, 12:25

    gotta do some checks before hand
  18. Benni Mack voted on patch set 4 CR +2 V +2 12/05/23, 12:28

  19. Benni Mack merged patch set 5 12/05/23, 12:28