Review main Merged

82081[BUGFIX] Add `#[Controller]` attribute to `EditController`

Oli Bartsch CR +2 V +2 Easy +2 −0 updated 12/04/23, 12:44

Commit message

The `EditController` uses DI since #102213 and must
therefore be declared public, which is done by setting
the corresponding `#[Controller]` attribute.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 12/04/23, 10:48

  2. Oliver Klee voted on patch set 1 CR +1 12/04/23, 10:51

  3. core-ci voted on patch set 1 V +1 12/04/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50316

  4. Oliver Hader commented on patch set 1 CR +1 V +1 12/04/23, 11:27

    I also checked the other adjusted classes of the related patch in https://review.typo3.org/c/Packages/TYPO3.CMS/+/81491 👍
  5. Oliver Hader voted on patch set 1 CR +2 V +2 12/04/23, 11:28

  6. Oliver Hader merged patch set 2 12/04/23, 11:28

  7. Christian Kuhn commented on patch set 2 CR +1 V +1 12/04/23, 12:44

    post +1