Review main Merged

82083[TASK] Register schedulable commands via `AsCommand` attribute

Oli Bartsch CR +2 V +2 Normal +34 −95 updated 12/08/23, 15:05

Commit message

Since #101567 it's possible to use the Symfony
`AsCommand` attribute to register commands.

This is now done for all schedulable commands.

Because Symfony's attribute does not support
the `schedulable` option, the non schedulable
commands are still registered in corresponding
`Services.yaml` files.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 24

Show 4 more files

Review log 78

  1. Oli Bartsch uploaded patch set 1 12/04/23, 15:40

  2. Oli Bartsch updated the commit message in patch set 2 12/04/23, 15:41

  3. core-ci voted on patch set 2 V +1 12/04/23, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50327

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 12/06/23, 08:55

  5. Jochen Roth voted on patch set 2 CR +1 V +1 12/06/23, 09:26

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 12/08/23, 14:07

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 12/08/23, 15:05

  8. Oli Bartsch merged patch set 3 12/08/23, 15:05