Review main Merged

82087[BUGFIX] Include records in Extbase without a l10n parent

Benni Mack CR +2 V +2 Normal +60 −3 updated 12/05/23, 12:40

Commit message

Within TYPO3's LanguageAspect there are four options for doing
overlays:
OVERLAYS_OFF -> fetch records in a specific language directly
OVERLAYS_MIXED -> fetch default records + do overlays if available
OVERLAYS_ON -> fetch default records + do overlays - discard if no overlay is available
OVERLAYS_ON_WITH_FLOATING -> same as OVERLAYS_ON PLUS the records that have no l10n_parent.

This change enables Extbase records to also be
fetched when using LanguageAspect::OVERLAYS_ON_WIITH_FLOATING
as floating records are the ones that do not have
a l10n_parent set ("copy mode").

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1218

  1. Benni Mack uploaded patch set 1 12/04/23, 23:41

  2. core-ci voted on patch set 1 V -1 12/04/23, 23:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50342

  3. Benni Mack uploaded patch set 2 V -1 12/04/23, 23:55

  4. core-ci voted on patch set 2 V -1 12/05/23, 00:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50343

  5. Benni Mack uploaded patch set 3 V -1 12/05/23, 00:07

  6. Benni Mack rebased onto patch set 4 12/05/23, 07:24

  7. core-ci voted on patch set 4 V -1 12/05/23, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50349

  8. Benni Mack uploaded patch set 5 V -1 12/05/23, 08:47

  9. core-ci voted on patch set 5 V +1 12/05/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50352

  10. Benni Mack updated the commit message in patch set 6 V +1 12/05/23, 08:56

  11. Benni Mack updated the commit message in patch set 7 12/05/23, 08:56

  12. core-ci voted on patch set 6 V +1 12/05/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50354

  13. core-ci voted on patch set 7 V +1 12/05/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50355

  14. Oliver Klee voted on patch set 7 V +1 12/05/23, 09:24

  15. Christian Kuhn voted on patch set 7 CR +1 V +1 12/05/23, 10:28

  16. Stefan Bürk voted on patch set 7 CR +1 V +1 12/05/23, 12:40

  17. Benni Mack voted on patch set 7 CR +2 V +2 12/05/23, 12:40

  18. Benni Mack merged patch set 8 12/05/23, 12:40