Review main Merged

82090[BUGFIX] Use "da" instead of "dk" for Danish language locale

Benni Mack CR +2 V +2 Hard +230 −230 updated 12/06/23, 09:42

Commit message

"DK" stands for "Denmark", whereas "da" stands for the Danish
language.

We should clean our mess up once and for all.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 48

Show 28 more files

Review log 1522

  1. Benni Mack uploaded patch set 1 12/05/23, 12:32

  2. core-ci voted on patch set 1 V +1 12/05/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50370

  3. Benni Mack uploaded patch set 2 V +1 12/05/23, 13:15

  4. core-ci voted on patch set 2 V -1 12/05/23, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50373

  5. Benni Mack uploaded patch set 3 V -1 12/05/23, 14:34

  6. core-ci voted on patch set 3 V -1 12/05/23, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50377

  7. Benni Mack commented on patch set 4 V -1 12/05/23, 15:20

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V -1 12/05/23, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50384

  9. Benni Mack commented on patch set 5 V -1 12/05/23, 15:28

    Published edit on patch set 4.
  10. core-ci voted on patch set 5 V +1 12/05/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50386

  11. Oliver Klee updated the commit message in patch set 6 V +1 12/05/23, 15:53

  12. core-ci voted on patch set 6 V +1 12/05/23, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50388

  13. Oliver Hader voted on patch set 6 CR +1 12/05/23, 18:34

  14. Garvin Hicking commented on patch set 6 CR +1 12/06/23, 08:30

    Haha. 😊 I also found these, maybe you could check: * `sysext/core/Classes/Site/SiteLanguagePresets.php` line 87 ('base', that might have an actual impact though?) * `typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php` lines 214-215, 244 * `typo3/sysext/backend/Resources/Private/tsref.xml` line 1068 * `typo3/sysext/core/Documentation/Changelog/9.0/Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst` line 39 (should be 'da'?) * `typo3/sysext/form/Documentation/D/FinisherOptions/Index.rst` line 429 ('da') * `typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/EmailToReceiver.rst` line 371 * `typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/EmailToSender.rst` line 371
  15. Benni Mack uploaded patch set 7 CR +1 V +1 12/06/23, 08:40

  16. Benni Mack commented on patch set 6 12/06/23, 08:40

    Reply

    Done
  17. core-ci voted on patch set 7 V +1 12/06/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50402

  18. Christian Kuhn voted on patch set 7 CR +1 V +1 12/06/23, 09:14

  19. Oliver Hader voted on patch set 7 CR +1 12/06/23, 09:29

  20. Oliver Hader voted on patch set 7 V +1 12/06/23, 09:29

  21. Benni Mack voted on patch set 7 CR +2 V +2 12/06/23, 09:42

  22. Benni Mack merged patch set 8 12/06/23, 09:42