Review 12.4 Merged

82120[BUGFIX] Use proper editor.css path within TYPO3

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 12/11/23, 16:27

Commit message

GeneralUtility::createVersionNumberedFilename() will process the
provided path. It will execute a file_exists check. The file therefore
needs to be resolvable. Applying getPublicResourceWebPath() beforehand
will result in a web url, which can not be resolved on file system
level.
We therefore remove the unnecessary getPublicResourceWebPath() call.
createVersionNumberedFilename() will resolve EXT: paths anyway.

That way TYPO3 can properly handle the file and add the corresponding
version number if configured.
Furthermore this resolves open_basedir restriction issues on configured
systems.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 12/11/23, 16:06

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 12/11/23, 16:06

  3. core-ci voted on patch set 1 V +1 12/11/23, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50564

  4. Benjamin Franzke merged patch set 2 12/11/23, 16:27