Review 12.4 Merged

82121[BUGFIX] Avoid exception on trailing comma in include_static_file.txt

Benni Mack CR +2 V +2 Easy +1 −1 updated 12/12/23, 16:10

Commit message

If an entry in the include_static_file.txt file contains a trailing
comma, a RuntimeException (1651137904) is thrown. The problem is a
check whether the path contains 'EXT:', in this case the second path
is an empty string and hence the exception is thrown.

The change removes empty strings when splitting the entries in the
file by comma.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 12/12/23, 15:53

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/12/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50605

  3. Benni Mack voted on patch set 1 CR +2 V +2 12/12/23, 16:10

  4. Benni Mack merged patch set 2 12/12/23, 16:10