Review 12.4 Merged

82129[BUGFIX] Prevent TypeError in FileSearchDemand

Oli Bartsch CR +2 V +2 Easy +4 −1 updated 12/18/23, 11:05

Commit message

Since `QueryHelper::parseOrderBy()` might return
NULL as value for fieldname and direction, we
now check those values properly to prevent any
TypeErrors using the type-hinted `addOrdering()`
method.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 12/18/23, 10:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/18/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50765

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 12/18/23, 11:05

  4. Oli Bartsch merged patch set 2 12/18/23, 11:05