Review main Merged

82132[BUGFIX] Validate arguments for ExpressionBuilder::in and notIn

Lina Wolf CR +2 V +2 Normal +64 −0 updated 12/06/23, 15:52

Commit message

And add Unit tests with empty array and empty string.
This behaviour is like ExpressionBuilder::inSet now.

This prevents a SyntaxErrorException by DBAL and gives a nicer
error to the developer which represents the Abstraction.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Lina Wolf uploaded patch set 1 12/06/23, 11:13

  2. core-ci voted on patch set 1 V +1 12/06/23, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50414

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 12/06/23, 13:07

    Good idea, would make debugging easier.
  4. Lina Wolf uploaded patch set 2 CR +1 V +1 12/06/23, 13:20

  5. core-ci voted on patch set 2 V +1 12/06/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50417

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 12/06/23, 13:57

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 12/06/23, 14:19

  8. Oliver Klee voted on patch set 2 CR +1 V +1 12/06/23, 15:34

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 12/06/23, 15:52

  10. Stefan Bürk merged patch set 3 12/06/23, 15:52