Review main Merged Breaking

82133[!!!][TASK] Mark most TSFE members internal or read-only

Christian Kuhn CR +2 V +2 Hard +433 −141 updated 12/07/23, 13:05

Commit message

Further TypoScriptFrontendController refactorings will remove
methods and properties, mainly by modeling state as request
attributes and moving methods into middlewares.

To enable this, the patch marks all public state as @internal
that is not crucially important for extensions, and marks the
rest read only. This allows removal of internal functionality
without further notice, plus a backwards compatible deprecation
layer for what is left. A similar strategy is established for
methods. A couple of type hints and general cleanup is applied
along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Oliver Klee +1
    • Sascha Nowak +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1117

  1. Christian Kuhn uploaded patch set 1 12/06/23, 13:29

  2. Christian Kuhn uploaded patch set 2 12/06/23, 13:29

  3. Christian Kuhn uploaded patch set 3 12/06/23, 13:34

  4. core-ci voted on patch set 1 V +1 12/06/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50418

  5. core-ci voted on patch set 2 V +1 12/06/23, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50419

  6. core-ci voted on patch set 3 V +1 12/06/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50421

  7. Christian Kuhn uploaded patch set 4 V +1 12/07/23, 08:53

  8. core-ci voted on patch set 4 V +1 12/07/23, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50439

  9. Christian Kuhn uploaded patch set 5 V +1 12/07/23, 11:48

  10. core-ci voted on patch set 5 V +1 12/07/23, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50443

  11. Christian Kuhn updated the commit message in patch set 6 V +1 12/07/23, 11:54

  12. core-ci voted on patch set 6 V +1 12/07/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50444

  13. Sascha Nowak voted on patch set 6 CR +1 12/07/23, 12:31

  14. Oliver Klee voted on patch set 6 CR +1 V +1 12/07/23, 12:43

  15. Benni Mack voted on patch set 6 CR +2 V +2 12/07/23, 12:56

  16. Christian Kuhn voted on patch set 6 CR +2 V +2 12/07/23, 13:00

  17. Christian Kuhn merged patch set 7 12/07/23, 13:05