Review main Abandoned

82134[BUGFIX] Allow to run CI tests on docker

Patrick Schriner CR 0 V 0 Easy +5 −1 updated 12/07/23, 13:33

Commit message

If you explicitly pass a container binary it is used in CI context as well.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1012

  1. Patrick Schriner uploaded patch set 1 12/06/23, 13:33

  2. core-ci voted on patch set 1 V -1 12/06/23, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50420

  3. Garvin Hicking commented on patch set 1 CR +1 12/06/23, 13:39

    runTests.sh:484 Unresolved

    I think this should be ``` if [ "${CONTAINER_BIN_FROM_ARG}" -eq 0 ]; then ``` to be aligned with the other equality checks of this file (it's funny when it all still works due to the full string evaluation passing as "true")
  4. Patrick Schriner uploaded patch set 2 CR +1 V -1 12/06/23, 13:39

  5. Stefan Bürk commented on patch set 1 CR -1 12/06/23, 13:40

    The core CI is only podman based, docker is not possible and not installed on the gitlab-runner. Therefore, this quirk has no impact on it for core work. For local machine execution see the `-b` arguement which can be used to pass ' docker' or 'podman' - and it works already. Build/Scripts/runTests.sh is not meant as product - so no need for this change. Also, it's not meant and build to be directly used somewhere else. Other implementations or extensions should copy it and make adjustments, and not using it directly. Maybe you can shine some light on the use case and why this should be done ?
  6. Patrick Schriner commented on patch set 2 12/06/23, 13:43

    Reply

    Hi Stefan, If that's the "Core" stance I'm fine with this. It was working quite well until the podman patch and it doesn't read intentional. But really, I'm fine if your stance is: that's not our problem
  7. core-ci voted on patch set 2 V +1 12/06/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50422

  8. Stefan Bürk commented on patch set 2 12/06/23, 13:46

    Reply

    Beside that, the implementation is hardly weired to the runner setup - and is not really usable outside the full setup as CI. And you will quickly hit limit issues using docker and the ghcr.io images as they could not be cached with docker.
  9. Stefan Bürk commented on patch set 2 12/06/23, 13:51

    Reply

    Please share your real/full use case - not getting it. I'm not blocking it yet, just want to elobarate the use case (and then maybe using another approch than adding a new variable to the mix). Beside the pure binary there is more involved. For example, our setup pulls the images into a folder - therefore the no pull flag. Using docker with non dockerhub images are not cacheable (without a quite hacky setup and proxies involved) - and therefore quickly hit rate limitings and involves a huge network IO / bandwith usages. The connected gitlab runner to gerrit and the core nightlies are not working with docker anymore - as no docker is installed on them. The other use case is to execute them locally - and there you can tell it with the `-b` what to use.
  10. Stefan Bürk commented on patch set 2 12/06/23, 14:56

    Reply Unresolved

    Note: Will have a call with Patrick lateron about the background. I'm adding the information from the call than later here.
  11. Christian Kuhn voted on patch set 2 CR -1 12/07/23, 06:54

  12. Patrick Schriner abandoned the change 12/07/23, 13:33

    will try another way - thanks for the feedback