82136[!!!][FEATURE] Add PSR-14 event for modifying GetData result
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102614-RemovedHookForManipulatingGetDataResult.rst2new+49 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102614-UnusedInterfaceForGetDataHook.rstnew+42 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102614-PSR-14EventForModifyingGetDataResult.rstnew+57 −0
- typo3/sysext/frontend/Classes/ContentObject/Event/AfterGetDataResolvedEvent.phpnew+58 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectGetDataHookInterface.php+3 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+5 −10
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+32 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/AfterGetDataResolvedEventTest.phpnew+59 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+7 −0
Review log 1520
-
Oli Bartsch uploaded patch set 1 12/06/23, 15:44
-
core-ci voted on patch set 1 V +1 12/06/23, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50424
-
Oli Bartsch uploaded patch set 2
V +112/06/23, 15:57 -
core-ci voted on patch set 2 V +1 12/06/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50426
-
Christian Kuhn commented on patch set 2 CR -1 12/07/23, 06:50
-
Christian Kuhn commented on patch set 2 12/07/23, 07:00
note we can have a chat on this today evening ;) -
Oli Bartsch uploaded patch set 3
CR -1V +112/07/23, 08:36 -
Oli Bartsch commented on patch set 3 12/07/23, 08:38
SingletonEventDispatcher.php:26ReplyThe problem was, that adding the EventDispatcherInterface as "single" instance, some tests failed, since they called the getData() multiple times. However I resolved it by adding the Interface to the container, passed to GU. Adding DI to COR will be a separate task. -
core-ci voted on patch set 3 V +1 12/07/23, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50438
-
Oli Bartsch commented on patch set 4
V +112/07/23, 10:18Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 12/07/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50441
-
Christian Kuhn voted on patch set 4 CR +1 V +1 12/07/23, 13:32
-
Jochen Roth commented on patch set 4 CR -1 12/07/23, 13:57
Breaking-102614-RemovedHookForManipulatingGetDataResult.rst:45"returned" -
Jochen Roth uploaded patch set 5
CR +1V +112/07/23, 14:00 -
Jochen Roth voted on patch set 5 CR +1 V +1 12/07/23, 14:00
-
core-ci voted on patch set 5 V +1 12/07/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50452
-
Christian Kuhn voted on patch set 5 CR +1 V +1 12/07/23, 14:13
-
Christian Kuhn commented on patch set 5 12/07/23, 14:39
Breaking-102614-RemovedHookForManipulatingGetDataResult.rst:45ReplyDone -
Christian Kuhn voted on patch set 5 CR +2 V +2 12/07/23, 14:39
-
Christian Kuhn merged patch set 6 12/07/23, 14:39
SingletonEventDispatcher.php:26