Review main Merged

82144[TASK] Avoid TSFE->lastImgResourceInfo

Christian Kuhn CR +2 V +2 Easy +0 −11 updated 12/07/23, 14:25

Commit message

With images nowadays handled by fluid or similar, there
is no need anymore to park the "last generated image" in
a property to operate on.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Christian Kuhn uploaded patch set 1 12/07/23, 13:58

  2. Benni Mack commented on patch set 1 12/07/23, 14:00

    Basically, it is not possible to use page.10 = IMAGE page.10.file = 1:/my_image.jpg page.20 = TEXT page.20.data = TSFE:lastImgResourceInfo|3 page.20.wrap = The image is of type: | anymore
  3. core-ci voted on patch set 1 V +1 12/07/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50451

  4. Benni Mack voted on patch set 1 CR +1 V +1 12/07/23, 14:21

  5. Christian Kuhn commented on patch set 1 12/07/23, 14:21

    Reply

    yes. this was never documented. it was just documented that lastImgResourceInfo was set, but nothing on what could be done with it. no example in data, either.
  6. Stefan Bürk voted on patch set 1 CR +1 V +1 12/07/23, 14:23

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 12/07/23, 14:25

  8. Christian Kuhn merged patch set 2 12/07/23, 14:25