Review main Merged Breaking

82145[!!!][FEATURE] Add PSR-14 event for modifying image source collection

Oli Bartsch CR +2 V +2 Hard +342 −33 updated 12/08/23, 09:37

Commit message

This introduces a new PSR-14 event, enabling
extension authors to modify the image source
collection of an ImageContentObject.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['getImageSourceCollection']
which is therefore now removed.

The hook required implementations to implement
the `ContentObjectOneSourceCollectionHookInterface`,
which is now deprecated as it's unused due to the
hook removal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 68

  1. Oli Bartsch uploaded patch set 1 12/07/23, 14:01

  2. core-ci voted on patch set 1 V -1 12/07/23, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50453

  3. Oli Bartsch uploaded patch set 2 V -1 12/07/23, 15:24

  4. core-ci voted on patch set 2 V +1 12/07/23, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50460

  5. Jochen Roth voted on patch set 2 CR +1 V +1 12/08/23, 08:54

  6. Benni Mack voted on patch set 2 CR +1 V +1 12/08/23, 08:56

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 12/08/23, 09:37

  8. Oli Bartsch merged patch set 3 12/08/23, 09:37