Review main Merged

82148[BUGFIX] Resolve itemsProcFunc in BackendUtility label functions

Oli Bartsch CR +2 V +2 Normal +126 −29 updated 12/09/23, 11:13

Commit message

A couple of BackendUtility methods dealing with resolving
labels do now also evaluate a configured `itemsProcFunc`
to properly resolve the corresponding labels.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1725

  1. Oli Bartsch uploaded patch set 1 12/07/23, 18:59

  2. core-ci voted on patch set 1 V -1 12/07/23, 19:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50465

  3. Oli Bartsch uploaded patch set 2 V -1 12/08/23, 08:35

  4. core-ci voted on patch set 2 V +1 12/08/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50475

  5. Oli Bartsch uploaded patch set 3 V +1 12/08/23, 08:45

  6. core-ci voted on patch set 3 V -1 12/08/23, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50476

  7. Oli Bartsch uploaded patch set 4 V -1 12/08/23, 09:33

  8. core-ci voted on patch set 4 V +1 12/08/23, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50479

  9. Jochen Roth uploaded patch set 5 V +1 12/08/23, 09:59

  10. core-ci voted on patch set 5 V +1 12/08/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50482

  11. Jochen Roth voted on patch set 5 CR +1 V +1 12/08/23, 10:54

  12. Christian Kuhn commented on patch set 5 12/08/23, 11:19

    BackendUtility.php:1342

    could use $$columnConfig as well

    BackendUtility.php:1349

    $columnConfig
  13. Oli Bartsch uploaded patch set 6 CR +1 V +1 12/08/23, 11:20

  14. Christian Kuhn commented on patch set 5 12/08/23, 11:20

  15. Oli Bartsch commented on patch set 6 12/08/23, 11:21

    BackendUtility.php:1342 Reply

    Done

    BackendUtility.php:1349 Reply

    Done
  16. core-ci voted on patch set 6 V +1 12/08/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50490

  17. Oli Bartsch uploaded patch set 7 V +1 12/08/23, 13:09

  18. core-ci voted on patch set 7 V +1 12/08/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50498

  19. Christian Kuhn uploaded patch set 8 V +1 12/08/23, 14:19

  20. Christian Kuhn voted on patch set 8 CR +1 V +1 12/08/23, 14:21

  21. core-ci voted on patch set 8 V +1 12/08/23, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50505

  22. Jochen Roth voted on patch set 8 CR +1 V +1 12/08/23, 15:05

  23. Oli Bartsch commented on patch set 8 CR +2 V +2 12/08/23, 15:31

    This currently triggers an "Undefined array key" warning in the page module, which however will be resolved in a separate patch.
  24. Oli Bartsch merged patch set 9 12/08/23, 15:48

  25. Simon Schaufelberger commented on patch set 9 12/09/23, 11:13

    Reply

    I've just noticed this myself and already wanted to report a bug.