Review main Merged

82149[BUGFIX] Ignore l10n_state when detaching localization parent

Oliver Hader CR +2 V +2 Easy +5 −0 updated 12/12/23, 10:27

Commit message

When an exisiting localization (sys_language_uid>0 and l10n_parent>0)
shall be detached (l10n_parent=0), the processing the l10n_state value
was skipped - basically since the processor assumes no adjustments
would be required.

The state is provided by FormEngine and is expected to be serialized
to JSON again in DataMapProcessor - in this case, the modifications
are just skipped as well.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Oliver Hader uploaded patch set 1 12/08/23, 08:23

  2. Oliver Hader commented on patch set 1 12/08/23, 08:24

    DataMapProcessor.php:237

    This part is kind of "ugly", since it breaks (again) the usual process flow and directly triggers the l10n_state serialization to JSON (which is required at some point).
  3. core-ci voted on patch set 1 V -1 12/08/23, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50474

  4. Benni Mack commented on patch set 1 12/08/23, 08:50

    good start, however we need to take the source field into account apparantly.
  5. Oliver Hader uploaded patch set 2 V -1 12/08/23, 11:57

  6. core-ci voted on patch set 2 V +1 12/08/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50493

  7. Oliver Hader commented on patch set 2 12/08/23, 12:53

    Reply

    Previous patch-set had a problem with casting and defaults... Changing (optional) `l10n_source` is not possible in the user interface - I'm not sure what the semantic meaning would be, when `l10n_source` was detached...
  8. Oliver Hader commented on patch set 2 12/11/23, 08:24

    DataMapProcessor.php:237 Reply

    Maybe a better approach would be to ensure that the `l10n_state` array is serialized - e.g. collected skipped items
  9. Oliver Hader uploaded patch set 3 V +1 12/11/23, 09:32

  10. core-ci voted on patch set 3 V +1 12/11/23, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50558

  11. Oliver Hader commented on patch set 3 12/11/23, 09:41

    This change is ready for review.
    Optional bonus: Adding a functional test

    DataMapProcessor.php:237 Reply

    Done
  12. Oliver Hader uploaded patch set 4 V +1 12/11/23, 09:41

  13. core-ci voted on patch set 4 V +1 12/11/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50560

  14. Benni Mack voted on patch set 4 CR +1 V +1 12/11/23, 10:27

  15. Georg Ringer voted on patch set 4 CR +1 V +1 12/11/23, 13:14

  16. Oliver Hader voted on patch set 4 CR +2 V +2 12/12/23, 10:26

  17. Oliver Hader merged patch set 5 12/12/23, 10:27