82149[BUGFIX] Ignore l10n_state when detaching localization parent
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1317
-
Oliver Hader uploaded patch set 1 12/08/23, 08:23
-
Oliver Hader commented on patch set 1 12/08/23, 08:24
-
core-ci voted on patch set 1 V -1 12/08/23, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50474
-
Benni Mack commented on patch set 1 12/08/23, 08:50
good start, however we need to take the source field into account apparantly. -
Oliver Hader uploaded patch set 2
V -112/08/23, 11:57 -
core-ci voted on patch set 2 V +1 12/08/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50493
-
Oliver Hader commented on patch set 2 12/08/23, 12:53
Reply
Previous patch-set had a problem with casting and defaults... Changing (optional) `l10n_source` is not possible in the user interface - I'm not sure what the semantic meaning would be, when `l10n_source` was detached... -
Oliver Hader commented on patch set 2 12/11/23, 08:24
DataMapProcessor.php:237ReplyMaybe a better approach would be to ensure that the `l10n_state` array is serialized - e.g. collected skipped items -
Oliver Hader uploaded patch set 3
V +112/11/23, 09:32 -
core-ci voted on patch set 3 V +1 12/11/23, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50558
-
Oliver Hader commented on patch set 3 12/11/23, 09:41
This change is ready for review.Optional bonus: Adding a functional testDataMapProcessor.php:237ReplyDone -
Oliver Hader uploaded patch set 4
V +112/11/23, 09:41 -
core-ci voted on patch set 4 V +1 12/11/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50560
-
Benni Mack voted on patch set 4 CR +1 V +1 12/11/23, 10:27
-
Georg Ringer voted on patch set 4 CR +1 V +1 12/11/23, 13:14
-
Oliver Hader voted on patch set 4 CR +2 V +2 12/12/23, 10:26
-
Oliver Hader merged patch set 5 12/12/23, 10:27
DataMapProcessor.php:237