Review main Merged

82151[FEATURE] Introduce AsController attribute for auto configuration

Oli Bartsch CR +2 V +2 Hard +311 −213 updated 12/08/23, 15:36

Commit message

This introduces a new PHP attribute `AsController`,
which serves as a drop-in replacement for the former
introduced `Controller` attribute (#99055), which is
now deprecated.

This is done to unify the naming of our attributes.

The old `Controller` attribute is still working using
class alias mapping.

For upwards compatibility, the #[AsController] attribute
will be backported to v12 with a more slim variant of
this patch.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 105

Show 85 more files

Review log 1925

  1. Oli Bartsch uploaded patch set 1 12/08/23, 10:48

  2. core-ci voted on patch set 1 V -1 12/08/23, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50487

  3. Oli Bartsch uploaded patch set 2 V -1 12/08/23, 11:00

  4. core-ci voted on patch set 2 V +1 12/08/23, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50488

  5. Chris Müller commented on patch set 2 12/08/23, 11:09

    Does it make sense to backport it also to 12.4 to ease the adoption? Then on upgrade to 12.4 developers use the Controller attribute, which then has to be changed again to AsController when upgrading to v13? Is see this similar to the AsCommand attribute.

    Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:16

    availale -> available
  6. Jochen Roth voted on patch set 2 CR +1 V +1 12/08/23, 11:10

  7. Oli Bartsch commented on patch set 3 CR +1 V +1 12/08/23, 11:18

    Published edit on patch set 2.
  8. Oli Bartsch commented on patch set 3 12/08/23, 11:18

    Reply

    This would mean we would need an exception for feature backporting. Based on the implications, I don't see this as critical for such exception.

    Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:16 Reply

    Done
  9. Jochen Roth voted on patch set 3 CR +1 V +1 12/08/23, 11:19

  10. core-ci voted on patch set 3 V +1 12/08/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50489

  11. Chris Müller commented on patch set 3 12/08/23, 11:46

    Reply

    Yup, but the AsCommand attribute was also backported to 12.4 as a task and was more a feature like this (which is just a "renaming").
  12. Christian Kuhn commented on patch set 3 12/08/23, 12:05

    Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:15

    automatically

    LinkValidatorController.php:47

    ?
  13. Christian Kuhn commented on patch set 3 12/08/23, 13:11

    Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:15 Reply

    Done

    LinkValidatorController.php:47 Reply

    Done
  14. Christian Kuhn uploaded patch set 4 CR +1 V +1 12/08/23, 13:12

  15. Jochen Roth voted on patch set 4 CR +1 V +1 12/08/23, 13:12

  16. core-ci voted on patch set 4 V +1 12/08/23, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50499

  17. Christian Kuhn uploaded patch set 5 CR +1 V +1 12/08/23, 13:21

  18. Christian Kuhn commented on patch set 4 12/08/23, 13:22

    +1 to backport the attribute to v12.
  19. core-ci voted on patch set 5 V +1 12/08/23, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50500

  20. Christian Kuhn uploaded patch set 6 V +1 12/08/23, 13:35

  21. Christian Kuhn voted on patch set 6 CR +1 V +1 12/08/23, 13:38

  22. Jochen Roth voted on patch set 6 CR +1 V +1 12/08/23, 13:44

  23. core-ci voted on patch set 6 V +1 12/08/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50501

  24. Oli Bartsch voted on patch set 6 CR +2 V +2 12/08/23, 15:36

  25. Oli Bartsch merged patch set 7 12/08/23, 15:36