82151[FEATURE] Introduce AsController attribute for auto configuration
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 105
- typo3/sysext/backend/Classes/Attribute/AsController.phprenamed+1 −1
- typo3/sysext/backend/Classes/Controller/CodeEditor/CodeCompletionController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/FileController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/ImageProcessController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/MovePageController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Security/SudoModeController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/SuggestWizardController.php+2 −2
Show 85 more files
- typo3/sysext/backend/Classes/Controller/AboutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+2 −2
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ClipboardController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php+2 −2
- typo3/sysext/backend/Classes/Controller/DummyController.php+2 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ElementBrowserController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LinkController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LogoutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+2 −2
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+2 −2
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/RecordListController.php+2 −2
- typo3/sysext/backend/Classes/Controller/RecordListDownloadController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ShortcutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SwitchUserController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SystemInformationController.php+2 −2
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspModuleController.php+2 −2
- typo3/sysext/backend/Configuration/Services.php+9 −0
- typo3/sysext/backend/Migrations/Code/ClassAliasMap.phpcopied+3 −12
- typo3/sysext/backend/Migrations/Code/LegacyClassesForIde.phpcopied+8 −10
- typo3/sysext/backend/composer.json+5 −0
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+2 −2
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99055-BackendControllerServiceTagAttribute.rst+11 −4
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102631-DeprecatedCommandAttributeForAutoConfiguringBackendControllers.rstnew+40 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst4new+42 −0
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+2 −2
- typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/File/CreateFileController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileDownloadController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileUpdateOnlineMediaController.php+2 −2
- typo3/sysext/impexp/Classes/Controller/ExportController.php+2 −2
- typo3/sysext/impexp/Classes/Controller/ImportController.php+2 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+2 −2
- typo3/sysext/info/Classes/Controller/PageInformationController.php+2 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+2 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php2+2 −2
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+2 −2
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+2 −2
- typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php+2 −2
- typo3/sysext/reactions/Classes/Controller/ManagementController.php+2 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+2 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+2 −2
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+2 −2
- typo3/sysext/redirects/Classes/Controller/RecordHistoryRollbackController.php+2 −2
- typo3/sysext/reports/Classes/Controller/ReportController.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/AvailableSchedulerTasksController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerSetupCheckController.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+2 −2
- typo3/sysext/styleguide/Classes/Controller/BackendController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/InfoModifyController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TemplateRecordsOverviewController.php+2 −2
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+2 −2
- typo3/sysext/webhooks/Classes/Controller/ManagementController.php+2 −2
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+2 −2
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+2 −2
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+2 −2
- composer.json+1 −0
- composer.lock+1 −1
Review log 1925
-
Oli Bartsch uploaded patch set 1 12/08/23, 10:48
-
core-ci voted on patch set 1 V -1 12/08/23, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50487
-
Oli Bartsch uploaded patch set 2
V -112/08/23, 11:00 -
core-ci voted on patch set 2 V +1 12/08/23, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50488
-
Chris Müller commented on patch set 2 12/08/23, 11:09
Does it make sense to backport it also to 12.4 to ease the adoption? Then on upgrade to 12.4 developers use the Controller attribute, which then has to be changed again to AsController when upgrading to v13? Is see this similar to the AsCommand attribute.Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:16availale -> available -
Jochen Roth voted on patch set 2 CR +1 V +1 12/08/23, 11:10
-
Oli Bartsch commented on patch set 3
CR +1V +112/08/23, 11:18Published edit on patch set 2. -
Oli Bartsch commented on patch set 3 12/08/23, 11:18
Reply
This would mean we would need an exception for feature backporting. Based on the implications, I don't see this as critical for such exception.Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:16ReplyDone -
Jochen Roth voted on patch set 3 CR +1 V +1 12/08/23, 11:19
-
core-ci voted on patch set 3 V +1 12/08/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50489
-
Chris Müller commented on patch set 3 12/08/23, 11:46
Reply
Yup, but the AsCommand attribute was also backported to 12.4 as a task and was more a feature like this (which is just a "renaming"). -
Christian Kuhn commented on patch set 3 12/08/23, 12:05
Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:15automaticallyLinkValidatorController.php:47? -
Christian Kuhn commented on patch set 3 12/08/23, 13:11
Feature-102631-IntroduceAsCommandAttributeToAutoconfigureBackendControllers.rst:15ReplyDoneLinkValidatorController.php:47ReplyDone -
Christian Kuhn uploaded patch set 4
CR +1V +112/08/23, 13:12 -
Jochen Roth voted on patch set 4 CR +1 V +1 12/08/23, 13:12
-
core-ci voted on patch set 4 V +1 12/08/23, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50499
-
Christian Kuhn uploaded patch set 5
CR +1V +112/08/23, 13:21 -
Christian Kuhn commented on patch set 4 12/08/23, 13:22
+1 to backport the attribute to v12. -
core-ci voted on patch set 5 V +1 12/08/23, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50500
-
Christian Kuhn uploaded patch set 6
V +112/08/23, 13:35 -
Christian Kuhn voted on patch set 6 CR +1 V +1 12/08/23, 13:38
-
Jochen Roth voted on patch set 6 CR +1 V +1 12/08/23, 13:44
-
core-ci voted on patch set 6 V +1 12/08/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50501
-
Oli Bartsch voted on patch set 6 CR +2 V +2 12/08/23, 15:36
-
Oli Bartsch merged patch set 7 12/08/23, 15:36