Review main Merged

82158[TASK] Avoid TSFE->getContext() and TSFE->getRequestedId()

Christian Kuhn CR +2 V +2 Normal +78 −160 updated 12/09/23, 18:25

Commit message

The context object is injectable singleton state - "Not good
but not terrible". There is no need to have a getter in
TypoScriptFrontendController for it. Refactor this. A test
case mocking can be simplified significantly with this.

The "originally requested id" can be retrieved from
the 'routing' Request attribute, there is not need to
carry a copy as TSFE property around.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 812

  1. Christian Kuhn uploaded patch set 1 12/09/23, 15:00

  2. core-ci voted on patch set 1 V -1 12/09/23, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50526

  3. Christian Kuhn uploaded patch set 2 V -1 12/09/23, 15:18

  4. core-ci voted on patch set 2 V +1 12/09/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50527

  5. Christian Kuhn uploaded patch set 3 V +1 12/09/23, 17:05

  6. Christian Kuhn updated the commit message in patch set 4 12/09/23, 17:06

  7. core-ci voted on patch set 3 V +1 12/09/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50530

  8. core-ci voted on patch set 4 V +1 12/09/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50531

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 12/09/23, 17:28

  10. Nikita Hovratov voted on patch set 4 CR +1 V +1 12/09/23, 18:22

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 12/09/23, 18:25

  12. Christian Kuhn merged patch set 5 12/09/23, 18:25