82162[TASK] Extract registration of controller actions into separate method
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1416
-
Nikita Hovratov uploaded patch set 1 12/09/23, 20:55
-
core-ci voted on patch set 1 V +1 12/09/23, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50538
-
Oliver Klee voted on patch set 1 CR +1 V +1 12/10/23, 10:10
-
Benni Mack commented on patch set 1 12/11/23, 07:01
-
Torben Hansen commented on patch set 1 12/11/23, 07:55
ExtensionUtility.php:102ReplyYes, lets do it. I think this is also a good chance to unify/simplify/harden the whole plugin registration/configuration code in extbase. Also fits good to this WIP patch (https://review.typo3.org/c/Packages/TYPO3.CMS/+/82154) for plugin registration/configuration in one configuration file. -
Nikita Hovratov uploaded patch set 2
CR +1V +112/11/23, 08:33 -
Nikita Hovratov commented on patch set 2 12/11/23, 08:35
ExtensionUtility.php:102ReplyGood idea, done. -
core-ci voted on patch set 2 V +1 12/11/23, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50555
-
Benni Mack voted on patch set 2 CR +1 12/11/23, 12:12
-
Oliver Klee voted on patch set 2 V +1 12/11/23, 13:02
-
Oli Bartsch commented on patch set 2 12/11/23, 14:18
ExtensionUtility.php:56Should we just call those in registerControllerActions()? -
Nikita Hovratov commented on patch set 2 12/11/23, 14:41
ExtensionUtility.php:56ReplyAccording to Benni: > if it is possible, we can make the actionList receive an array of arrays for this method (= do this in the "original" method), which would solve another issue for registration in the future. I think the idea is to have a clean new API, without built-in migrations. -
Benni Mack commented on patch set 2 12/11/23, 14:49
ExtensionUtility.php:56Replyexactly. we declined a change in the past for v12 to add an array of actions instead of the list. theoretically this is now in place for future work. -
Garvin Hicking voted on patch set 2 CR +1 V +1 12/13/23, 10:33
-
Oli Bartsch commented on patch set 2 CR +2 V +2 12/13/23, 13:40
ExtensionUtility.php:56ReplyAcknowledged -
Oli Bartsch merged patch set 3 12/13/23, 13:57
ExtensionUtility.php:102