82171[FEATURE] Enable item groups for foreign_table
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php4+6 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/Extensions/test_tca_select_items/ext_tables.sql+1 −0
- typo3/sysext/backend/Tests/Functional/Form/Fixtures/TcaSelectItems/base.csv+7 −7
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+62 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-95808-EnableItemGroupsFromForeignTables.rstnew+57 −0
- typo3/sysext/core/Documentation/Settings.cfg+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTableGroupField.phpnew+79 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorResolver.php+1 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_select.php+24 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_select_single_21_foreign.phpnew+100 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/styleguide/ext_tables.sql2+4 −0
Review log 2837
Show 912 earlier messages
-
Oli Bartsch uploaded patch set 1 12/11/23, 17:12
-
core-ci voted on patch set 1 V +1 12/11/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50567
-
Mathias Brodala commented on patch set 1 12/12/23, 07:18
-
Oli Bartsch commented on patch set 1 12/13/23, 10:13
AbstractItemProvider.php:362ReplyWhat values are you thinking about? The value should be the groupId string, as documented in https://docs.typo3.org/m/typo3/reference-tca/main/en-us/ColumnsConfig/Type/Select/Properties/Items.html#items. We could think about using an empty() check, like done for the static items https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php#L166. But actually, the correct check - taking the docs into account - would be: `is_string($foreignRow[$itemGroupField] ?? false)` -
Mathias Brodala commented on patch set 1 12/13/23, 10:29
AbstractItemProvider.php:362ReplyIt was not clear from reading that the field on the foreign row is required to be a string. I thought it could be anything including numbers or similar. It could make sense to group by such values. -
Oli Bartsch uploaded patch set 2
V +112/14/23, 11:11 -
Oli Bartsch commented on patch set 2 12/14/23, 11:15
AbstractItemProvider.php:362ReplyOk. To be fully consistent, a group is now always set for foreign_table items, as it's done in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php#L1049C30-L1049C37 for all other items. Additionally, I added the link to the documentation, stating that this should be a string, to the RST. -
core-ci voted on patch set 2 V +1 12/14/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50649
-
Chris Müller uploaded patch set 3
V +112/14/23, 16:59 -
core-ci voted on patch set 3 V +1 12/14/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50659
-
Nikita Hovratov uploaded patch set 4
V +112/15/23, 13:34 -
Nikita Hovratov commented on patch set 4 12/15/23, 13:36
I've added a field generator for the styleguide foreign table relation.
-
core-ci voted on patch set 4 V +1 12/15/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50700
-
Nikita Hovratov voted on patch set 4 CR +1 V +1 12/15/23, 13:46
-
Jochen Roth voted on patch set 4 CR +1 V +1 12/18/23, 08:43
-
Christian Kuhn commented on patch set 4 CR -1 12/18/23, 10:22
let's please wait with this until the 'db type=select fields' patch is in to not introduce new ext_tables.sql fields anymore. -
Oli Bartsch uploaded patch set 5
CR +1V +112/19/23, 21:04 -
Oli Bartsch commented on patch set 5 12/19/23, 21:04
Reply
Done -
Christian Kuhn commented on patch set 5 CR -1 12/19/23, 21:06
Reply
are the ext_tables.sql changes still needed? -
Oli Bartsch uploaded patch set 6
CR -112/19/23, 21:07 -
Christian Kuhn commented on patch set 6 12/19/23, 21:09
ext_tables.sql:119make it a varchar(255)? there is no need to make it bigger. (currently working on type=input auto-generation ;) -
core-ci voted on patch set 5 V +1 12/19/23, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50822
-
core-ci voted on patch set 6 V +1 12/19/23, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50823
-
Oli Bartsch uploaded patch set 7
V +112/19/23, 21:23 -
Oli Bartsch commented on patch set 7 12/19/23, 21:24
Reply
Yes, since type=input is not yet covered by auto generation.ext_tables.sql:119ReplyDone -
core-ci voted on patch set 7 V +1 12/19/23, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50824
-
Oli Bartsch rebased onto patch set 8
V +112/27/23, 09:40 -
core-ci voted on patch set 8 V +1 12/27/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50962
-
Anja Leichsenring voted on patch set 8 CR +1 V +1 01/03/24, 08:10
-
Anja Leichsenring commented on patch set 8 V -1 01/03/24, 08:16
some issue with varchar fields, Oli is informed. -
Oli Bartsch uploaded patch set 9
CR +1V +101/03/24, 09:19 -
Oli Bartsch commented on patch set 9 01/03/24, 09:20
Reply
No db issue, TCA 'allowNonIdValues' setting was missing. -
core-ci voted on patch set 9 V +1 01/03/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51065
-
Nikita Hovratov voted on patch set 9 CR +1 V +1 01/03/24, 22:20
-
Anja Leichsenring voted on patch set 9 CR +1 V +1 01/04/24, 05:49
-
Oli Bartsch voted on patch set 9 CR +2 V +2 01/04/24, 07:22
-
Oli Bartsch merged patch set 10 01/04/24, 07:22
AbstractItemProvider.php:362