Review main Merged

82180[BUGFIX] Properly handle module access for workspaces

Oli Bartsch CR +2 V +2 Normal +218 −23 updated 12/15/23, 08:40

Commit message

This fixes a couple of workspace related issues
in the module access evaluation.

Basically, it's now ensured that the user will
never be confronted with an exception for cases
where he is in a module, which is not allowed in
a workspace and then switches the workspace.

This also applies for deep links. Therefore, the
the start module evaluation, taking the redirect
into account, is now respecting the fact that the
given module might be temporarily not accessible.

Finally the inheritance of the workspace access
restriction is restored by changing the default
value in the BaseModule and respecting the parent
module's configuration for sub modules in the
access check. Previously it was possible to
access such sub modules, e.g. the site configuration
module in a workspace by using a deep link.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Achim Fritz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Achim Fritz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 812

  1. Oli Bartsch uploaded patch set 1 12/13/23, 08:39

  2. core-ci voted on patch set 1 V -1 12/13/23, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50615

  3. Oli Bartsch uploaded patch set 2 V -1 12/13/23, 09:40

  4. core-ci voted on patch set 2 V +1 12/13/23, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50618

  5. Oli Bartsch uploaded patch set 3 V +1 12/13/23, 15:39

  6. core-ci voted on patch set 3 V +1 12/13/23, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50624

  7. Oli Bartsch uploaded patch set 4 V +1 12/13/23, 16:09

  8. core-ci voted on patch set 4 V +1 12/13/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50625

  9. Achim Fritz voted on patch set 4 CR +1 V +1 12/14/23, 06:34

  10. Benni Mack voted on patch set 4 CR +1 V +1 12/15/23, 07:54

  11. Oli Bartsch voted on patch set 4 CR +2 V +2 12/15/23, 08:40

  12. Oli Bartsch merged patch set 5 12/15/23, 08:40