Review 12.4 Merged

82181[TASK] Extract registration of controller actions into separate method

Oli Bartsch CR +2 V +2 Normal +84 −16 updated 12/13/23, 13:57

Commit message

EU::configurePlugin tightly couples registration of controller actions
and TypoScript generation for a frontend rendering definition.
Furthermore, lib.contentElement is only defined in fluid_styled_content,
which makes it an indirect requirement.

This patch extracts the part for the controller action registration, so
it can be used independently of fluid_styled_content. In addition, this
new method expects the controller actions to have an array shape
already. A converter method ensures compatibility for both string and
array syntax.

A concrete use-case for internal usage would be Content Blocks, as it
would be possible to separately define a Content Block of type "Plugin"
and in addition register controller actions for it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch uploaded patch set 1 12/13/23, 13:46

  2. core-ci voted on patch set 1 V +1 12/13/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50621

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 12/13/23, 13:57

  4. Oli Bartsch merged patch set 2 12/13/23, 13:57